flip the list-as-tuple behavior for short lists#160794
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160794
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 178d6de with merge base 3008d98 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -c ghfirst -m "This if failing internal tests, see D80671241" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit febfc3e. Reverted #160794 on behalf of https://github.com/seemethere due to This if failing internal tests, see D80671241 ([comment](#160794 (comment)))
|
@ngimel your PR has been successfully reverted. |
Per title, previously we started throwing noisy warnings, but given how popular this pattern was in our test suite decided to leave it as warning, not as silent behavior change for one release. Now `treatSequenceAsTuple` would return `true` in the only case where the sequence was indeed a tuple, so no need for a special function anymore. Pull Request resolved: pytorch#160794 Approved by: https://github.com/albanD
…)" This reverts commit febfc3e. Reverted pytorch#160794 on behalf of https://github.com/seemethere due to This if failing internal tests, see D80671241 ([comment](pytorch#160794 (comment)))
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Per title, previously we started throwing noisy warnings, but given how popular this pattern was in our test suite decided to leave it as warning, not as silent behavior change for one release.
Now
treatSequenceAsTuplewould returntruein the only case where the sequence was indeed a tuple, so no need for a special function anymore.