stop suggesting using guard_size_oblivious on data dependent errors#160510
stop suggesting using guard_size_oblivious on data dependent errors#160510laithsakka wants to merge 2 commits intogh/laithsakka/260/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160510
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 75388ad with merge base a8d6943 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| desc = "Could not guard on data-dependent expression" | ||
| size_oblivious_result_msg = ( | ||
| "consider using data-dependent friendly APIs such as " | ||
| "guard_or_false, guard_or_true and statically_known_true" |
There was a problem hiding this comment.
I am suggesting "guard_or_false, guard_or_true and statically_known_true"
instead of suggesting guard_size_oblivious.
maybe user on code data dependent errors or things we did not handle yet,
There was a problem hiding this comment.
I guess I would probably advise NOT giving a suggestion (or linking to docs) if it requires user discretion to figure out how to resolve. Because otherwise someone will just blindly paste the suggested call in without understanding what it does.
…nt errors" cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: inductor / inductor-cpu-build / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i "not related" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: inductor / inductor-cpu-build / build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ytorch#160510) Pull Request resolved: pytorch#160510 Approved by: https://github.com/ezyang
…ytorch#160510) Pull Request resolved: pytorch#160510 Approved by: https://github.com/ezyang
…ytorch#160510) Pull Request resolved: pytorch#160510 Approved by: https://github.com/ezyang
Stack from ghstack (oldest at bottom):
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv