[c10d] Fix test test_nccl_user_buffer_registration#160497
Closed
fduwjj wants to merge 1 commit intogh/fduwjj/181/basefrom
Closed
[c10d] Fix test test_nccl_user_buffer_registration#160497fduwjj wants to merge 1 commit intogh/fduwjj/181/basefrom
fduwjj wants to merge 1 commit intogh/fduwjj/181/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160497
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f32d02b with merge base 2d0cdee ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ngimel
approved these changes
Aug 13, 2025
| @requires_multicast_support() | ||
| def test_nccl_user_buffer_registration(self): | ||
| store = c10d.FileStore(self.file_name, self.world_size) | ||
| device = torch.device(f"cuda:{self.rank}") |
Collaborator
There was a problem hiding this comment.
not for this PR, but it's better for tests to not have side-effects, so device should be a context manager
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 14, 2025
Fixed `test_nccl_user_buffer_registration ` due to #160145, somehow CI didn't capture it. Pull Request resolved: #160497 Approved by: https://github.com/ngimel
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 18, 2025
Fixed `test_nccl_user_buffer_registration ` due to #160145, somehow CI didn't capture it. Pull Request resolved: #160497 Approved by: https://github.com/ngimel
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
Fixed `test_nccl_user_buffer_registration ` due to pytorch#160145, somehow CI didn't capture it. Pull Request resolved: pytorch#160497 Approved by: https://github.com/ngimel
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Fixed `test_nccl_user_buffer_registration ` due to pytorch#160145, somehow CI didn't capture it. Pull Request resolved: pytorch#160497 Approved by: https://github.com/ngimel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixed
test_nccl_user_buffer_registrationdue to #160145, somehow CI didn't capture it.cc @H-Huang @awgu @wanchaol @fegin @wz337 @wconstab @d4l3k @pragupta