Change IR node's stack trace to be computed lazily#160487

Closed

yushangdi wants to merge 1 commit intopytorch:mainfrom

yushangdi:export-D80137870

Contributor

yushangdi commented Aug 13, 2025 •

edited by pytorch-bot bot

Loading

Summary: When an IR node is an inherited class, post_init is called once for each super().init() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

pytorch-bot bot commented Aug 13, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160487

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8406ec9 with merge base 7d87e35 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor labels

Contributor

facebook-github-bot commented Aug 13, 2025

This pull request was exported from Phabricator. Differential Revision: D80137870

facebook-github-bot added the fb-exported label

yushangdi requested a review from angelayi

August 13, 2025 00:59

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

b1dc4a3

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

yushangdi force-pushed the export-D80137870 branch from 7142100 to b1dc4a3 Compare

August 13, 2025 01:01

Contributor

facebook-github-bot commented Aug 13, 2025

This pull request was exported from Phabricator. Differential Revision: D80137870

yushangdi force-pushed the export-D80137870 branch from b1dc4a3 to 93bc553 Compare

August 13, 2025 01:05

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

93bc553

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

Contributor

facebook-github-bot commented Aug 13, 2025

This pull request was exported from Phabricator. Differential Revision: D80137870

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

e588ff5

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

yushangdi force-pushed the export-D80137870 branch from 93bc553 to e588ff5 Compare

August 13, 2025 01:06

Contributor

facebook-github-bot commented Aug 13, 2025

This pull request was exported from Phabricator. Differential Revision: D80137870

angelayi approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

yushangdi added the topic: not user facing label


          Change IR node's stack trace to be computed lazily (pytorch#160487)

8406ec9

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

yushangdi force-pushed the export-D80137870 branch from e588ff5 to 8406ec9 Compare

August 13, 2025 16:37

Contributor

facebook-github-bot commented Aug 13, 2025

This pull request was exported from Phabricator. Differential Revision: D80137870

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

59704ea

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Reviewed By: angelayi

Differential Revision: D80137870

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

a571457

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Reviewed By: angelayi

Differential Revision: D80137870

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

860e7d2

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Reviewed By: angelayi

Differential Revision: D80137870

yushangdi added a commit to yushangdi/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

cbd651b

Summary:

When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Reviewed By: angelayi

Differential Revision: D80137870

Contributor

facebook-github-bot commented Aug 13, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

d1950d4

pytorchmergebot removed the merging label

chuanhaozhuge pushed a commit that referenced this pull request


          Change IR node's stack trace to be computed lazily (#160487)

Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

Pull Request resolved: #160487
Approved by: https://github.com/angelayi

chuanhaozhuge pushed a commit that referenced this pull request


          Change IR node's stack trace to be computed lazily (#160487)

92ac91b

Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

Pull Request resolved: #160487
Approved by: https://github.com/angelayi

can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

06fecd9

Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

Pull Request resolved: pytorch#160487
Approved by: https://github.com/angelayi

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request


          Change IR node's stack trace to be computed lazily (pytorch#160487)

c127d9e

Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily.

Test Plan:
CI

Rollback Plan:

Differential Revision: D80137870

Pull Request resolved: pytorch#160487
Approved by: https://github.com/angelayi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged module: inductor topic: not user facing