Skip to content

Add getCurrentDeviceIndex to torch::stable::accelerator#160453

Closed
mikaylagawarecki wants to merge 6 commits intogh/mikaylagawarecki/334/basefrom
gh/mikaylagawarecki/334/head
Closed

Add getCurrentDeviceIndex to torch::stable::accelerator#160453
mikaylagawarecki wants to merge 6 commits intogh/mikaylagawarecki/334/basefrom
gh/mikaylagawarecki/334/head

Conversation

@mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 12, 2025 •
edited
Loading

@mikaylagawarecki mikaylagawarecki mentioned this pull request Aug 12, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160453

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6d3c097 with merge base 34ec5ed (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 12, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
659695c 
ghstack-source-id: 3d1d730
Pull Request resolved: #160453
mikaylagawarecki added a commit that referenced this pull request Aug 12, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
cd6dacc 
ghstack-source-id: ac1977c
Pull Request resolved: #160453
@mikaylagawarecki mikaylagawarecki marked this pull request as ready for review August 12, 2025 19:59
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

janeyx99
janeyx99 reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, but code looks great otherwise

mikaylagawarecki added a commit that referenced this pull request Aug 13, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
1913517 
ghstack-source-id: 7f73999
Pull Request resolved: #160453
@mikaylagawarecki mikaylagawarecki changed the title Add get_current_device to torch::stable::accelerator Add getCurrentDeviceIndex to torch::stable::accelerator Aug 13, 2025
janeyx99
janeyx99 approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@mikaylagawarecki mikaylagawarecki added release notes: build release notes category topic: new features topic category labels Aug 13, 2025
@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 13, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 13, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team Raised by workflow job

mikaylagawarecki added a commit that referenced this pull request Aug 13, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
72342f8 
ghstack-source-id: 7ddca94
Pull Request resolved: #160453
mikaylagawarecki added a commit that referenced this pull request Aug 13, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
178efe9 
ghstack-source-id: cd646c1
Pull Request resolved: #160453
@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 13, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

mikaylagawarecki added a commit that referenced this pull request Aug 13, 2025
@mikaylagawarecki
Add get_current_device to torch::stable::accelerator
4e7e883 
ghstack-source-id: 501ab51
Pull Request resolved: #160453
@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 13, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 13, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@mikaylagawarecki
Copy link
Contributor Author

mikaylagawarecki commented Aug 13, 2025

@pytorchbot merge -f "ci is green on top PR and bottom PR has flaky test that can't be merge -i"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 13, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
@mikaylagawarecki @chuanhaozhuge
Add getCurrentDeviceIndex to torch::stable::accelerator (#160453)
80f3aea 
Pull Request resolved: #160453
Approved by: https://github.com/janeyx99
ghstack dependencies: #159679
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
@mikaylagawarecki @chuanhaozhuge
Add getCurrentDeviceIndex to torch::stable::accelerator (#160453)
c550f17 
Pull Request resolved: #160453
Approved by: https://github.com/janeyx99
ghstack dependencies: #159679
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@mikaylagawarecki @can-gaa-hou
Add getCurrentDeviceIndex to torch::stable::accelerator (pytorch#160453)
a217e5e 
Pull Request resolved: pytorch#160453
Approved by: https://github.com/janeyx99
ghstack dependencies: pytorch#159679
@github-actions github-actions bot deleted the gh/mikaylagawarecki/334/head branch September 13, 2025 02:06
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@mikaylagawarecki @markc-614
Add getCurrentDeviceIndex to torch::stable::accelerator (pytorch#160453)
d14bab4 
Pull Request resolved: pytorch#160453
Approved by: https://github.com/janeyx99
ghstack dependencies: pytorch#159679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category release notes: inductor (aoti) topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikaylagawarecki @pytorchmergebot @janeyx99