Skip to content

Fix collective schedule logging and runtime tests#160260

Closed
skarjala wants to merge 3 commits intogh/skarjala/18/basefrom
gh/skarjala/18/head
Closed

Fix collective schedule logging and runtime tests#160260
skarjala wants to merge 3 commits intogh/skarjala/18/basefrom
gh/skarjala/18/head

Conversation

@skarjala
Copy link
Contributor

@skarjala skarjala commented Aug 10, 2025 •
edited
Loading

@skarjala
Update
4c4f859 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160260

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f81f213 with merge base 8147370 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

skarjala added a commit that referenced this pull request Aug 10, 2025
@skarjala
fix tests
f308edc 
ghstack-source-id: 653df30
Pull-Request: #160260
@skarjala skarjala changed the title fix tests Fix collective schedule logging and runtime tests Aug 10, 2025
@skarjala
Update
fdc1d11 
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 10, 2025
@skarjala
fix tests
7ebf067 
ghstack-source-id: 1f9321b
Pull-Request: #160260

update test_recompiles
@skarjala
Copy link
Contributor Author

skarjala commented Aug 10, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 10, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 10, 2025

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@skarjala skarjala added the topic: not user facing topic category label Aug 11, 2025
@skarjala
Copy link
Contributor Author

skarjala commented Aug 11, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot pytorchmergebot mentioned this pull request Aug 11, 2025
Closed
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2025

Merge failed

Reason: PR #160132 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@skarjala
Copy link
Contributor Author

skarjala commented Aug 11, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2025

Merge failed

Reason: PR #160132 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@skarjala
Update
f81f213 
[ghstack-poisoned]
@skarjala
Copy link
Contributor Author

skarjala commented Aug 11, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 11, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

samanklesaria pushed a commit to samanklesaria/pytorch that referenced this pull request Aug 12, 2025
@skarjala @samanklesaria
Fix collective schedule logging and runtime tests (pytorch#160260)
0d3135b 
Summary:

- Fix collective schedule logging so that only logs when collectives present
- Fix runtime estimate test to check if each op has a number value

Pull Request resolved: pytorch#160260
Approved by: https://github.com/Skylion007
pytorchmergebot pushed a commit that referenced this pull request Aug 16, 2025
@skarjala @pytorchmergebot
[inductor] TLParse tensor metadata logging + test (#160132)
2603e40 
Summary:
- Add TLParse artifact logging per op with output tensor shape, stride, and dtype for cross-rank aggregation.

Testing:
- Add test to verify structure and contents of tlparse artifiact

Pull Request resolved: #160132
Approved by: https://github.com/xmfan
ghstack dependencies: #160260
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@skarjala @can-gaa-hou
[inductor] TLParse tensor metadata logging + test (pytorch#160132)
a8413c3 
Summary:
- Add TLParse artifact logging per op with output tensor shape, stride, and dtype for cross-rank aggregation.

Testing:
- Add test to verify structure and contents of tlparse artifiact

Pull Request resolved: pytorch#160132
Approved by: https://github.com/xmfan
ghstack dependencies: pytorch#160260
@github-actions github-actions bot deleted the gh/skarjala/18/head branch September 11, 2025 02:11
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@skarjala @markc-614
Fix collective schedule logging and runtime tests (pytorch#160260)
bf868cb 
Summary:

- Fix collective schedule logging so that only logs when collectives present
- Fix runtime estimate test to check if each op has a number value

Pull Request resolved: pytorch#160260
Approved by: https://github.com/Skylion007
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@skarjala @markc-614
[inductor] TLParse tensor metadata logging + test (pytorch#160132)
8d84779 
Summary:
- Add TLParse artifact logging per op with output tensor shape, stride, and dtype for cross-rank aggregation.

Testing:
- Add test to verify structure and contents of tlparse artifiact

Pull Request resolved: pytorch#160132
Approved by: https://github.com/xmfan
ghstack dependencies: pytorch#160260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skarjala @pytorchmergebot @Skylion007