[DCP][HF] Add option to parallelize reads in HF Storage Reader#160205
Closed
ankitageorge wants to merge 5 commits intogh/ankitageorge/21/basefrom
Closed
[DCP][HF] Add option to parallelize reads in HF Storage Reader#160205ankitageorge wants to merge 5 commits intogh/ankitageorge/21/basefrom
ankitageorge wants to merge 5 commits intogh/ankitageorge/21/basefrom
Conversation
Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160205
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ecd2d16 with merge base e1a64b7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ankitageorge
added a commit
that referenced
this pull request
Aug 8, 2025
Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) ghstack-source-id: 300233804 Pull Request resolved: #160205
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79478188 |
Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 11, 2025
Parallelize reading of data behind thread_count argument to HFStorageReader Pull Request resolved: #160205 ghstack-source-id: 302209653 @exported-using-ghexport Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79478188 |
…ader" Parallelize reading of data behind thread_count argument to HFStorageReader Test plan: ensure existing tests pass and run a job successfully with these changes Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 12, 2025
Parallelize reading of data behind thread_count argument to HFStorageReader Pull Request resolved: #160205 ghstack-source-id: 302487332 @exported-using-ghexport Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79478188 |
meetv18
approved these changes
Aug 21, 2025
Contributor
meetv18
left a comment
There was a problem hiding this comment.
LGTM :)
Any way to modularize this and also implement it for FileSystemReader?
saumishr
reviewed
Aug 21, 2025
| except queue.Empty: | ||
| pass | ||
|
|
||
| def read_data(self, plan: LoadPlan, planner: LoadPlanner) -> Future[None]: |
Contributor
There was a problem hiding this comment.
Is there a plan to introduce the multithreading for save path as well?
Contributor
Author
There was a problem hiding this comment.
it's already there
|
|
||
| target_tensor.copy_(tensor) | ||
| planner.commit_tensor(req, target_tensor) | ||
| if self.thread_count <= 1 or len(per_file) <= 1: |
Contributor
There was a problem hiding this comment.
We need a test for this method.
…ader" Parallelize reading of data behind thread_count argument to HFStorageReader Test plan: ensure existing tests pass and run a job successfully with these changes Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 21, 2025
Parallelize reading of data behind thread_count argument to HFStorageReader Pull Request resolved: #160205 ghstack-source-id: 304719983 @exported-using-ghexport Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79478188 |
…ader" Parallelize reading of data behind thread_count argument to HFStorageReader Test plan: ensure existing tests pass and run a job successfully with these changes Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta [ghstack-poisoned]
ankitageorge
added a commit
that referenced
this pull request
Aug 21, 2025
Parallelize reading of data behind thread_count argument to HFStorageReader Pull Request resolved: #160205 ghstack-source-id: 304745088 @exported-using-ghexport Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79478188 |
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wincent8
pushed a commit
to wincent8/pytorch
that referenced
this pull request
Aug 22, 2025
…ch#160205) Parallelize reading of data behind thread_count argument to HFStorageReader Test plan: ensure existing tests pass and run a job successfully with these changes Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) Pull Request resolved: pytorch#160205 Approved by: https://github.com/meetv18
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ch#160205) Parallelize reading of data behind thread_count argument to HFStorageReader Test plan: ensure existing tests pass and run a job successfully with these changes Differential Revision: [D79478188](https://our.internmc.facebook.com/intern/diff/D79478188/) Pull Request resolved: pytorch#160205 Approved by: https://github.com/meetv18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallelize reading of data behind thread_count argument to HFStorageReader
Test plan: ensure existing tests pass and run a job successfully with these changes
Stack from ghstack (oldest at bottom):
Differential Revision: D79478188
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta