Remove benchmark dependencies from regular ROCm CI images#160047
Closed
huydhn wants to merge 2 commits intopytorch:mainfrom
Closed
Remove benchmark dependencies from regular ROCm CI images#160047huydhn wants to merge 2 commits intopytorch:mainfrom
huydhn wants to merge 2 commits intopytorch:mainfrom
Conversation
Signed-off-by: Huy Do <huydhn@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160047
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit a2639c9 with merge base 2507ae6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| @@ -192,6 +192,21 @@ case "$tag" in | |||
| UCC_COMMIT=${_UCC_COMMIT} | |||
| INDUCTOR_BENCHMARKS=yes | |||
Collaborator
There was a problem hiding this comment.
Works, although could be made more concise by having a condition like: if [[ $tag =~ "benchmarks" ]]; to avoid repetition
Signed-off-by: Huy Do <huydhn@gmail.com>
malfet
approved these changes
Aug 7, 2025
izaitsevfb
approved these changes
Aug 7, 2025
Contributor
Author
|
@pytorchbot merge -f 'ROCm signals looks ok' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Aug 12, 2025
Follow-up to pytorch#160047 that separated the rocm image into default CI and benchmarks.
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 12, 2025
Follow-up to #160047 that separated the rocm image into default CI and benchmarks. Pull Request resolved: #160421 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 14, 2025
Follow-up to #160047 that separated the rocm image into default CI and benchmarks. Pull Request resolved: #160421 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
chuanhaozhuge
pushed a commit
that referenced
this pull request
Aug 18, 2025
Follow-up to #160047 that separated the rocm image into default CI and benchmarks. Pull Request resolved: #160421 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
can-gaa-hou
pushed a commit
to can-gaa-hou/pytorch
that referenced
this pull request
Aug 22, 2025
Follow-up to pytorch#160047 that separated the rocm image into default CI and benchmarks. Pull Request resolved: pytorch#160421 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…0047) Instead, use a new `pytorch-linux-jammy-rocm-n-py3-benchmarks` image for Docker benchmark job. This addresses 2 issues: * The current ROCm failures in trunk w.r.t librosa version https://github.com/pytorch/pytorch/actions/runs/16789466749/job/47549950994 that TorchBench pulls in. * Reduce the size of the regular ROCm CI images by removing TorchBench models, which is needed only for benchmarking jobs. Pull Request resolved: pytorch#160047 Approved by: https://github.com/malfet, https://github.com/izaitsevfb
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Follow-up to pytorch#160047 that separated the rocm image into default CI and benchmarks. Pull Request resolved: pytorch#160421 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, use a new
pytorch-linux-jammy-rocm-n-py3-benchmarksimage for Docker benchmark job. This addresses 2 issues:cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd