Make user defined Triton kernels serializable for fx_graph_runnable by PaulZhang12 · Pull Request #160002 · pytorch/pytorch

PaulZhang12 · 2025-08-06T22:12:00Z

Stack from ghstack (oldest at bottom):

-> Make user defined Triton kernels serializable for fx_graph_runnable #160002

Resolves issue #153475 where fx_graph_runnable didn't work with user defined triton kernels.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2025-08-06T22:12:04Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160002

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit e3f0f6c with merge base a4b07fe ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4) (gh) (similar failure)
distributed/test_c10d_nccl.py::ProcessGroupNCCLGroupTest::test_extra_cuda_context

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
/var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 85122df Pull Request resolved: #160002

…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: 9e7b3ff Pull Request resolved: #160002

…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: aa8bc86 Pull Request resolved: #160002

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: 0f1c159 Pull Request resolved: #160002

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: aea2f34 Pull Request resolved: #160002

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: 75dac19 Pull Request resolved: #160002

eellison

🚢 🚢 🚢

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: 55cb448 Pull Request resolved: #160002

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: b9e7e42 Pull Request resolved: #160002

PaulZhang12 · 2025-08-09T06:40:40Z

@pytorchbot merge

pytorchmergebot · 2025-08-09T06:42:59Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

albanD · 2025-08-09T14:00:16Z

@pytorchbot revert -m "Breaks inductor tests in trunk" -c nosignal

See https://hud.pytorch.org/pytorch/pytorch/commit/4183d4ff3dcc1d87400326a9a7998c3f9e966f60 for the details

pytorchmergebot · 2025-08-09T14:01:47Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2025-08-09T14:02:00Z

@PaulZhang12 your PR has been successfully reverted.

…nnable (#160002)" This reverts commit 4183d4f. Reverted #160002 on behalf of https://github.com/albanD due to Breaks inductor tests in trunk ([comment](#160002 (comment)))

…_runnable" Resolves issue #153475 where `fx_graph_runnable` didn't work with user defined triton kernels. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

ghstack-source-id: cc99938 Pull Request resolved: #160002

PaulZhang12 · 2025-08-11T20:52:05Z

@pytorchbot merge

pytorchmergebot · 2025-08-11T20:54:04Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison

…runnable (#160002)" Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187

…runnable (pytorch#160002)" (pytorch#160436) Summary: Pull Request resolved: pytorch#160436 Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187

…runnable (pytorch#160002)" (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187

…n attributes (#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: #160436 Approved by: https://github.com/clee2000

… contain attributes (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: pytorch#160436 Approved by: https://github.com/clee2000

…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison

…nnable (pytorch#160002)" This reverts commit 4183d4f. Reverted pytorch#160002 on behalf of https://github.com/albanD due to Breaks inductor tests in trunk ([comment](pytorch#160002 (comment)))

…ytorch#160002) Resolves issue pytorch#153475 where `fx_graph_runnable` didn't work with user defined triton kernels. Pull Request resolved: pytorch#160002 Approved by: https://github.com/eellison

… contain attributes (pytorch#160436) Summary: Fixes internal test failures of D80037015 Test Plan: CI Rollback Plan: Differential Revision: D80094187 Pull Request resolved: pytorch#160436 Approved by: https://github.com/clee2000

Make user defined Triton kernels serializable for fx_graph_runnable

219825c

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Aug 6, 2025

PaulZhang12 added a commit that referenced this pull request Aug 6, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

498da47

ghstack-source-id: 85122df Pull Request resolved: #160002

Update on "Make user defined Triton kernels serializable for fx_graph…

6f7c8cd

…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

c81d29a

ghstack-source-id: 9e7b3ff Pull Request resolved: #160002

Update on "Make user defined Triton kernels serializable for fx_graph…

584bf0f

…_runnable" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

bf4291d

ghstack-source-id: aa8bc86 Pull Request resolved: #160002

pytorch-bot bot added the release notes: fx release notes category label Aug 7, 2025

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

07ebf76

ghstack-source-id: 0f1c159 Pull Request resolved: #160002

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

b2b8111

ghstack-source-id: aea2f34 Pull Request resolved: #160002

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

49d6bbe

ghstack-source-id: 75dac19 Pull Request resolved: #160002

PaulZhang12 requested a review from eellison August 7, 2025 17:11

eellison approved these changes Aug 7, 2025

View reviewed changes

PaulZhang12 added a commit that referenced this pull request Aug 7, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

e587b8f

ghstack-source-id: 55cb448 Pull Request resolved: #160002

eellison mentioned this pull request Aug 7, 2025

Inductor codegen for float8 dynamic quantization ops for scaled_grouped_mm backward pass is slow #159769

Open

PaulZhang12 added a commit that referenced this pull request Aug 8, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

942ac8c

ghstack-source-id: b9e7e42 Pull Request resolved: #160002

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 9, 2025

pytorchmergebot added the merging label Aug 9, 2025

pytorchmergebot added the Merged label Aug 9, 2025

pytorchmergebot closed this in 4183d4f Aug 9, 2025

pytorchmergebot removed the merging label Aug 9, 2025

pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 9, 2025

pytorchmergebot reopened this Aug 9, 2025

PaulZhang12 added a commit that referenced this pull request Aug 11, 2025

Make user defined Triton kernels serializable for fx_graph_runnable

2f169b7

ghstack-source-id: cc99938 Pull Request resolved: #160002

pytorchmergebot added the merging label Aug 11, 2025

pytorchmergebot closed this in cf0a0dc Aug 11, 2025

pytorchmergebot removed the merging label Aug 11, 2025

PaulZhang12 mentioned this pull request Aug 13, 2025

User Triton Kernels Are not Serialized in Fx Graph Runnable #153475

Closed

github-actions bot deleted the gh/PaulZhang12/21/head branch September 11, 2025 02:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make user defined Triton kernels serializable for fx_graph_runnable#160002

Make user defined Triton kernels serializable for fx_graph_runnable#160002
PaulZhang12 wants to merge 9 commits intogh/PaulZhang12/21/basefrom
gh/PaulZhang12/21/head

PaulZhang12 commented Aug 6, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Aug 6, 2025 •

edited

Loading

Uh oh!

eellison left a comment

Uh oh!

PaulZhang12 commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Uh oh!

albanD commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Uh oh!

PaulZhang12 commented Aug 11, 2025

Uh oh!

pytorchmergebot commented Aug 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

PaulZhang12 commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160002

✅ You can merge normally! (2 Unrelated Failures)

Uh oh!

eellison left a comment

Choose a reason for hiding this comment

Uh oh!

PaulZhang12 commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Merge started

Uh oh!

albanD commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Uh oh!

pytorchmergebot commented Aug 9, 2025

Uh oh!

PaulZhang12 commented Aug 11, 2025

Uh oh!

pytorchmergebot commented Aug 11, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PaulZhang12 commented Aug 6, 2025 •

edited

Loading

pytorch-bot bot commented Aug 6, 2025 •

edited

Loading