Change mutation type of `MutableMappingVariable` to `AttributeMutationNew` by guilhermeleobas · Pull Request #159366 · pytorch/pytorch

guilhermeleobas · 2025-07-29T14:33:26Z

Stack from ghstack (oldest at bottom):

Also add MutableMappingVariable to call_or_ / call_ior

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

[ghstack-poisoned]

pytorch-bot · 2025-07-29T14:33:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159366

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0e1acc4 with merge base e299926 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
vision_maskrcnn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

zou3519 · 2025-08-13T22:43:50Z

torch/_dynamo/variables/user_defined.py

        super().__init__(value, **kwargs)
        self.generic_dict_vt = variables.ConstDictVariable({})
-        self.mutation_type = AttributeMutationExisting()
+        self.mutation_type = AttributeMutationNew()


I don't understand this one, is there an explanation on why it should be AttributeMutationNew vs AttributeMutationExisting ?

From the source code:

class AttributeMutationExisting(AttributeMutation): """ This case of VariableTracker.mutation_type marker indicates 1. ... 2. The value exists before Dynamo tracing started. """ ... class AttributeMutationNew(AttributeMutation): """ This case of VariableTracker.mutation_type marker indicates 1. ... 2. The value is created by the bytecode Dynamo is tracing through. """ ...

The value has no source and cannot be AttributeMutationExisting.

MutableMapping looks like it can have a source? or is this branch dead: https://github.com/pytorch/pytorch/blob/a06ec54d40013c97fbffc174ea8f524ea5a95715/torch/_dynamo/variables/builder.py#L1525C38-L1527

You're right. So, the mutation type depends on whether MutableMapping has a source or not.

[ghstack-poisoned]

pytorchmergebot · 2025-08-15T00:27:42Z

Starting merge as part of PR stack under #159483

pytorchmergebot · 2025-08-15T14:49:35Z

Starting merge as part of PR stack under #159368

[ghstack-poisoned]

pytorchmergebot · 2025-08-15T18:28:53Z

Starting merge as part of PR stack under #159483

Pull Request resolved: #159368 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366

Pull Request resolved: #159483 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368

#159902) Pull Request resolved: #159902 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483

…159864) Pull Request resolved: #159864 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902

…ts (#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: #159865 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864

Pull Request resolved: #159367 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864, #159865

…nNew` (pytorch#159366) Also add MutableMappingVariable to `call_or_` / `call_ior` Pull Request resolved: pytorch#159366 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#159365

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

…nNew` (pytorch#159366) Also add MutableMappingVariable to `call_or_` / `call_ior` Pull Request resolved: pytorch#159366 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#159365

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

Pull Request resolved: pytorch#159483 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368

pytorch#159902) Pull Request resolved: pytorch#159902 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483

…ytorch#159864) Pull Request resolved: pytorch#159864 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902

…ts (pytorch#159865) Changes: (1) Replace UserDefinedSetVariable by UserDefinedObjectVariable in all binop calls Test plan: (1) The three tests from CPython `test_collections.py` ensures that Dynamo can trace through a dunder method (e.g. __add__, __ixor__, etc) defined in a user defined class Pull Request resolved: pytorch#159865 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864

Pull Request resolved: pytorch#159367 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366, pytorch#159368, pytorch#159483, pytorch#159902, pytorch#159864, pytorch#159865

Update

a7bd5e8

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Jul 29, 2025

This was referenced Jul 29, 2025

Enable trace through the collections module #159365

Closed

Fixes for collections.NamedTuple #159367

Closed

Fixes for collections.Counter #159368

Closed

guilhermeleobas added the topic: not user facing topic category label Jul 29, 2025

Update

55e9b26

[ghstack-poisoned]

pytorchbot added the open source label Jul 29, 2025

guilhermeleobas mentioned this pull request Jul 30, 2025

Don't call _call_iter_tuple_list with UserDefinedObjectVariable arg #159402

Closed

guilhermeleobas added 2 commits July 30, 2025 12:50

Update

9c80086

[ghstack-poisoned]

Update

fdbb7d9

[ghstack-poisoned]

guilhermeleobas marked this pull request as ready for review August 1, 2025 14:29

guilhermeleobas mentioned this pull request Aug 1, 2025

Support next(iterator, default) #159483

Closed

Update

bbda954

[ghstack-poisoned]

This was referenced Aug 5, 2025

Implement list(UserDefinedObject) via force_unpack_var_sequence #159864

Closed

[collections.abc] Ensure that binop calls works with UserDefinedObjects #159865

Closed

guilhermeleobas requested a review from anijain2305 August 5, 2025 14:10

Update

470ce11

[ghstack-poisoned]

guilhermeleobas mentioned this pull request Aug 5, 2025

Wrap class definitions in set_fullgraph(False) in test_collections #159902

Closed

zou3519 reviewed Aug 13, 2025

View reviewed changes

Update

aa39c67

[ghstack-poisoned]

zou3519 approved these changes Aug 14, 2025

View reviewed changes

guilhermeleobas added 3 commits August 14, 2025 14:33

Update

bc418a1

[ghstack-poisoned]

Update

c36bdef

[ghstack-poisoned]

Update

88e9261

[ghstack-poisoned]

Update

0e1acc4

[ghstack-poisoned]

pytorchmergebot closed this in 2542e71 Aug 15, 2025

pytorchmergebot added the Merged label Aug 15, 2025

pytorchmergebot pushed a commit that referenced this pull request Aug 15, 2025

Fixes for collections.Counter (#159368)

e5621b4

Pull Request resolved: #159368 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366

pytorchmergebot pushed a commit that referenced this pull request Aug 15, 2025

Support next(iterator, default) (#159483)

b78968b

Pull Request resolved: #159483 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368

pytorchmergebot pushed a commit that referenced this pull request Aug 16, 2025

Wrap class definitions in set_fullgraph(False) in test_collections (

f1bc843

#159902) Pull Request resolved: #159902 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483

pytorchmergebot pushed a commit that referenced this pull request Aug 18, 2025

Fixes for collections.NamedTuple (#159367)

c6333f7

Pull Request resolved: #159367 Approved by: https://github.com/mlazos ghstack dependencies: #159365, #159366, #159368, #159483, #159902, #159864, #159865

can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025

Fixes for collections.Counter (pytorch#159368)

f026f14

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

github-actions bot deleted the gh/guilhermeleobas/215/head branch September 15, 2025 02:15

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025

Fixes for collections.Counter (pytorch#159368)

5c70975

Pull Request resolved: pytorch#159368 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#159365, pytorch#159366

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change mutation type of `MutableMappingVariable` to `AttributeMutationNew`#159366

Change mutation type of `MutableMappingVariable` to `AttributeMutationNew`#159366
guilhermeleobas wants to merge 11 commits intogh/guilhermeleobas/215/basefrom
gh/guilhermeleobas/215/head

guilhermeleobas commented Jul 29, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 29, 2025 •

edited

Loading

Uh oh!

zou3519 Aug 13, 2025 •

edited

Loading

Uh oh!

guilhermeleobas Aug 14, 2025 •

edited

Loading

Uh oh!

zou3519 Aug 14, 2025

Uh oh!

guilhermeleobas Aug 14, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

guilhermeleobas commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159366

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

zou3519 Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zou3519 Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

pytorchmergebot commented Aug 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

guilhermeleobas commented Jul 29, 2025 •

edited

Loading

pytorch-bot bot commented Jul 29, 2025 •

edited

Loading

zou3519 Aug 13, 2025 •

edited

Loading

guilhermeleobas Aug 14, 2025 •

edited

Loading