Skip to content

[BE] [dynamo] Simplify two methods in ConstDictVariable#159361

Closed
rec wants to merge 5 commits intogh/rec/160/basefrom
gh/rec/160/head
Closed

[BE] [dynamo] Simplify two methods in ConstDictVariable#159361
rec wants to merge 5 commits intogh/rec/160/basefrom
gh/rec/160/head

Conversation

@rec
Copy link
Collaborator

@rec rec commented Jul 29, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159361

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit d21570a with merge base 284b719 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

rec added a commit that referenced this pull request Jul 29, 2025
ghstack-source-id: d01deb7
Pull Request resolved: #159361
@rec rec added better-engineering Relatively self-contained tasks for better engineering contributors topic: not user facing topic category labels Jul 29, 2025
@rec rec marked this pull request as ready for review July 30, 2025 09:17
@rec rec requested a review from anijain2305 July 30, 2025 09:18
@rec
Copy link
Collaborator Author

rec commented Jul 30, 2025

@anijain2305: near-trivial change that simplifies and probably speeds up ConstDictVariable.len and ConstDictVariable.has_new_items.

@rec
Copy link
Collaborator Author

rec commented Aug 5, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Aug 5, 2025
ghstack-source-id: 236597b
Pull Request resolved: #159361
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/rec/160/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/159361)

[ghstack-poisoned]
rec added a commit that referenced this pull request Aug 6, 2025
ghstack-source-id: f875479
Pull Request resolved: #159361
[ghstack-poisoned]
rec added a commit that referenced this pull request Aug 11, 2025
ghstack-source-id: 9deeeb3
Pull Request resolved: #159361
[ghstack-poisoned]
rec added a commit that referenced this pull request Aug 19, 2025
@rec rec changed the title [dynamo] Simplify two methods in ConstDictVariable [BE] [dynamo] Simplify two methods in ConstDictVariable Aug 19, 2025
@rec
Copy link
Collaborator Author

rec commented Aug 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 22, 2025
@rec
Copy link
Collaborator Author

rec commented Aug 22, 2025

@anijain2305 Thanks for the approve!

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@github-actions github-actions bot deleted the gh/rec/160/head branch September 22, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants