Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159240
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 62eb2ca with merge base f15ada5 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
left a comment
There was a problem hiding this comment.
LGTM.
Adding a test case is better.
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
|
Test case https://github.com/pytorch/pytorch/blob/main/test/distributed/optim/test_zero_redundancy_optimizer.py could verify ddp zero hook XCCL path, and test file no need device agnostic. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
| # NCCL/HCCL/XCCL backend for now; see https://github.com/pytorch/pytorch/issues/62300 | ||
| pg = dist.get_backend(ddp_ref().process_group) # type: ignore[union-attr] | ||
| if (pg != dist.Backend.NCCL) and (pg != "hccl"): | ||
| if (pg != dist.Backend.NCCL) and (pg != "hccl") and (pg != "xccl"): |
There was a problem hiding this comment.
Shouldn't we just blacklist Gloo in the future if that is the problematic backend?
There was a problem hiding this comment.
We don't need to update any XFAIL or SKIPIF in tests, right?
There was a problem hiding this comment.
Sure, let me blacklist Gloo and try ci, no need update any tests.
|
@Skylion007 Thanks very much~ |
|
@pytorchbot merge |
|
@pytorchbot rebase -b main |
|
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
|
Successfully rebased |
ec4c619 to
62eb2ca
Compare
|
@pytorchbot merge |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
XCCL backend no #62300 issue, add xccl path here. Pull Request resolved: #159240 Approved by: https://github.com/guangyey, https://github.com/Skylion007, https://github.com/EikanWang
XCCL backend no #62300 issue, add xccl path here. Pull Request resolved: #159240 Approved by: https://github.com/guangyey, https://github.com/Skylion007, https://github.com/EikanWang
XCCL backend no pytorch#62300 issue, add xccl path here. Pull Request resolved: pytorch#159240 Approved by: https://github.com/guangyey, https://github.com/Skylion007, https://github.com/EikanWang
XCCL backend no pytorch#62300 issue, add xccl path here. Pull Request resolved: pytorch#159240 Approved by: https://github.com/guangyey, https://github.com/Skylion007, https://github.com/EikanWang
XCCL backend no #62300 issue, add xccl path here.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta