Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159157
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit 1b6f53c with merge base 204eb4d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
commented
Jul 25, 2025
Collaborator
Author
albanD
left a comment
There was a problem hiding this comment.
Added the newline !
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
yangw-dev
pushed a commit
that referenced
this pull request
Aug 1, 2025
Following comment from #158475 (comment) Also this is a fake issue as protoc is dead anyways: #159156 Also also, macos cross compilation is not something that is tested :/ But I guess we're ok with that given how niche it it... Pull Request resolved: #159157 Approved by: https://github.com/janeyx99
blawrence-ont
added a commit
to blawrence-ont/pytorch
that referenced
this pull request
Oct 21, 2025
When this was brought back in pytorch#159157 it didn't have the executable bit set like it was previously. This caused macOS builds to fail if CMAKE_OSX_ARCHITECTURES was set, even if it's set to the same arch as the host.
pytorchmergebot
pushed a commit
to blawrence-ont/pytorch
that referenced
this pull request
Oct 23, 2025
When this was brought back in pytorch#159157 it didn't have the executable bit set like it was previously. This caused macOS builds to fail if CMAKE_OSX_ARCHITECTURES was set, even if it's set to the same arch as the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following comment from #158475 (comment)
Also this is a fake issue as protoc is dead anyways: #159156
Also also, macos cross compilation is not something that is tested :/ But I guess we're ok with that given how niche it it...