Skip to content

Add avg_pool3d for MPS#158877

Closed
kurtamohler wants to merge 7 commits intogh/kurtamohler/42/basefrom
gh/kurtamohler/42/head
Closed

Add avg_pool3d for MPS#158877
kurtamohler wants to merge 7 commits intogh/kurtamohler/42/basefrom
gh/kurtamohler/42/head

Conversation

@kurtamohler
Copy link
Copy Markdown
Collaborator

@kurtamohler kurtamohler commented Jul 22, 2025 •
edited
Loading

@kurtamohler
Update
c1e7052 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158877

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 1 Unrelated Failure

As of commit 9c6a091 with merge base 2d1e923 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kurtamohler added a commit that referenced this pull request Jul 22, 2025
@kurtamohler
Add avg_pool3d for MPS
d6a16ca 
ghstack-source-id: 91af932
Pull-Request: #158877
@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category release notes: inductor (aoti) labels Jul 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

@kurtamohler
Update
1194077 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Jul 22, 2025
@kurtamohler
Add avg_pool3d for MPS
44d5353 
ghstack-source-id: 2352732
Pull-Request: #158877
@kurtamohler
Update
0e0e82e 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Jul 23, 2025
@kurtamohler
Add avg_pool3d for MPS
c44a7aa 
ghstack-source-id: 15a5e7b
Pull-Request: #158877
@kurtamohler kurtamohler marked this pull request as ready for review July 23, 2025 19:50
@kurtamohler
Update
ad33603 
[ghstack-poisoned]
kurtamohler added a commit that referenced this pull request Jul 23, 2025
@kurtamohler
Add avg_pool3d for MPS
be099ba 
ghstack-source-id: da454e9
Pull-Request: #158877
@kurtamohler kurtamohler mentioned this pull request Jul 8, 2025
Open
@kurtamohler
Update
85c0d98 
[ghstack-poisoned]
@kurtamohler kurtamohler mentioned this pull request Jul 24, 2025
Closed
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Jul 24, 2025
@kurtamohler
Add avg_pool3d for MPS
5a5d41d 
ghstack-source-id: ff0d6c5
Pull-Request: pytorch#158877
@kurtamohler
Update
d125fe3 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Jul 25, 2025
@kurtamohler
Add avg_pool3d for MPS
06335de 
ghstack-source-id: 5e924f3
Pull-Request: pytorch#158877
@malfet malfet added the topic: improvements topic category label Jul 25, 2025
malfet
malfet approved these changes Jul 25, 2025
View reviewed changes
@kurtamohler
Update
9c6a091 
[ghstack-poisoned]
kurtamohler added a commit to kurtamohler/pytorch that referenced this pull request Jul 28, 2025
@kurtamohler
Add avg_pool3d for MPS
2cac306 
ghstack-source-id: b727d04
Pull-Request: pytorch#158877
@kurtamohler
Copy link
Copy Markdown
Collaborator Author

kurtamohler commented Jul 29, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 29, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 29, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: Check Labels / Check labels, pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 29, 2025

Merge failed

Reason: HTTP Error 504: Gateway Timeout

Details for Dev Infra team Raised by workflow job

@kurtamohler
Copy link
Copy Markdown
Collaborator Author

kurtamohler commented Jul 29, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 29, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, linux.12xlarge, unstable), trunk / macos-py3-arm64 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

yangw-dev pushed a commit that referenced this pull request Aug 1, 2025
@kurtamohler @yangw-dev
Add avg_pool3d for MPS (#158877)
33791cc 
Pull Request resolved: #158877
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the gh/kurtamohler/42/head branch August 29, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/inductor ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: inductor (aoti) release notes: mps Release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kurtamohler @pytorchmergebot @malfet @pytorchbot