Skip to content

Fix docker image creation#158634

Closed
AlekseiNikiforovIBM wants to merge 1 commit intopytorch:mainfrom
AlekseiNikiforovIBM:docker_image_fix_symlink_creation
Closed

Fix docker image creation#158634
AlekseiNikiforovIBM wants to merge 1 commit intopytorch:mainfrom
AlekseiNikiforovIBM:docker_image_fix_symlink_creation

Conversation

@AlekseiNikiforovIBM
Copy link
Collaborator

@AlekseiNikiforovIBM AlekseiNikiforovIBM commented Jul 18, 2025

Since switching from wheel 0.34.2 to wheel 0.45.1
python symlinks are no longer correctly created.

Migrate to packaging package for symlink creation

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158634

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Unrelated Failure

As of commit eeb3fe4 with merge base 2507ae6 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

  • pull / linux-jammy-py3_9-clang9-xla / test (xla, 1, 1, lf.linux.12xlarge, unstable) (gh) (#158876)
    /var/lib/jenkins/workspace/xla/torch_xla/csrc/runtime/BUILD:476:14: Compiling torch_xla/csrc/runtime/xla_util_test.cpp failed: (Exit 1): gcc failed: error executing CppCompile command (from target //torch_xla/csrc/runtime:xla_util_test) /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 229 arguments skipped)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 18, 2025
@AlekseiNikiforovIBM AlekseiNikiforovIBM added the ciflow/s390 s390x-related CI jobs label Jul 18, 2025
@AlekseiNikiforovIBM
Copy link
Collaborator Author

AlekseiNikiforovIBM commented Jul 18, 2025

This change should fix issues like this:
https://github.com/pytorch/pytorch/actions/runs/16344164134/job/46173557558

@AlekseiNikiforovIBM AlekseiNikiforovIBM marked this pull request as ready for review July 18, 2025 16:09
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 23, 2025
@AlekseiNikiforovIBM
Copy link
Collaborator Author

AlekseiNikiforovIBM commented Aug 7, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@AlekseiNikiforovIBM @pytorchmergebot
Fix docker image creation
eeb3fe4 
Since switching from wheel 0.34.2 to wheel 0.45.1
python symlinks are no longer correctly created.

Migrate to packaging package for symlink creation
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

Successfully rebased docker_image_fix_symlink_creation onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout docker_image_fix_symlink_creation && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the docker_image_fix_symlink_creation branch from 35456bc to eeb3fe4 Compare August 7, 2025 09:34
@malfet
Copy link
Contributor

malfet commented Aug 7, 2025

@pytorchbot merge -f "This seems fine"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

Merge failed

Reason: PR #158634 has not been reviewed yet

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Copy link
Contributor

malfet commented Aug 7, 2025

@pytorchbot merge -f "Let's test in prod"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 7, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@AlekseiNikiforovIBM @markc-614
Fix docker image creation (pytorch#158634)
9194816 
Since switching from wheel 0.34.2 to wheel 0.45.1
python symlinks are no longer correctly created.

Migrate to packaging package for symlink creation
Pull Request resolved: pytorch#158634
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@huydhn huydhn Awaiting requested review from huydhn

@seemethere seemethere Awaiting requested review from seemethere

Assignees

No one assigned

Labels

ciflow/s390 s390x-related CI jobs Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlekseiNikiforovIBM @pytorchmergebot @malfet @soulitzer @pytorchbot