Skip to content

[ROCm][CI] update fbgemm_gpu hash used by inductor tests#158602

Closed
naromero77amd wants to merge 5 commits intopytorch:mainfrom
ROCm:rocm_fbgemm_hash_update
Closed

[ROCm][CI] update fbgemm_gpu hash used by inductor tests#158602
naromero77amd wants to merge 5 commits intopytorch:mainfrom
ROCm:rocm_fbgemm_hash_update

Conversation

@naromero77amd
Copy link
Collaborator

@naromero77amd naromero77amd commented Jul 17, 2025 •
edited by jeffdaily
Loading

fbgemm_gpu build started failing with asmjit errors. Moving to latest tip of fbgemm for inductor tests resolves the build failures.

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang

@naromero77amd naromero77amd requested a review from a team as a code owner July 17, 2025 23:02
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158602

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (6 Unrelated Failures)

As of commit 6b0bdbb with merge base 393377d (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added module: rocm AMD GPU support for Pytorch release notes: releng release notes category labels Jul 17, 2025
@jeffdaily jeffdaily changed the title [ROCm][CI] update fbgemm hash [ROCm][CI] update fbgemm_gpu hash used by inductor tests Jul 17, 2025
@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Jul 17, 2025
@jeffdaily jeffdaily added topic: not user facing topic category ciflow/inductor-periodic and removed release notes: releng release notes category ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Jul 17, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025

To add the ciflow label ciflow/inductor-periodic please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

jeffdaily
jeffdaily previously approved these changes Jul 17, 2025
View reviewed changes
@jeffdaily
Copy link
Collaborator

jeffdaily commented Jul 17, 2025

Fixes these errors.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm labels Jul 17, 2025
@pytorch-bot pytorch-bot bot removed ciflow/inductor ciflow/rocm Trigger "default" config CI on ROCm ciflow/inductor-periodic labels Jul 18, 2025
@jeffdaily
Copy link
Collaborator

jeffdaily commented Jul 18, 2025

@pytorchbot merge -f "rocm-only change to docker image, lintrunner ran locally and fixed"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 18, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi
Copy link
Contributor

ZainRizvi commented Jul 18, 2025

@pytorchbot revert -c nosignal -m "The lint job failure was hiding a real lint failure. See here for more details: GH job link HUD commit link"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 18, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 18, 2025
@pytorchmergebot
Revert "[ROCm][CI] update fbgemm_gpu hash used by inductor tests (#15…
86675af 
…8602)"

This reverts commit 9308261.

Reverted #158602 on behalf of https://github.com/ZainRizvi due to The lint job failure was hiding a real lint failure. See here for more details: [GH job link](https://github.com/pytorch/pytorch/actions/runs/16375911199/job/46275682191) [HUD commit link](https://hud.pytorch.org/pytorch/pytorch/commit/6f73e067963e31d16840fbc34993a64cee698746) ([comment](#158602 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 18, 2025

@naromero77amd your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 18, 2025
@pytorch-bot pytorch-bot bot dismissed jeffdaily’s stale review July 18, 2025 17:46

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@naromero77amd naromero77amd marked this pull request as draft July 21, 2025 15:04
@jeffdaily jeffdaily marked this pull request as ready for review July 21, 2025 16:08
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 21, 2025

To add the ciflow label ciflow/inductor-periodic please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@naromero77amd
Copy link
Collaborator Author

naromero77amd commented Jul 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 22, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

saienduri pushed a commit to saienduri/pytorch that referenced this pull request Jul 22, 2025
@naromero77amd @jeffdaily @saienduri
[ROCm][CI] update fbgemm_gpu hash used by inductor tests (pytorch#158602
abe12c5 
)

fbgemm_gpu build started failing with asmjit errors.  Moving to latest tip of fbgemm for inductor tests resolves the build failures.

Pull Request resolved: pytorch#158602
Approved by: https://github.com/jeffdaily

Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor-periodic ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naromero77amd @jeffdaily @pytorchmergebot @ZainRizvi @pytorchbot