Skip to content

[CI][MPS] Enable test_indexing on MPS#158582

Closed
malfet wants to merge 2 commits intogh/malfet/438/basefrom
gh/malfet/438/head
Closed

[CI][MPS] Enable test_indexing on MPS#158582
malfet wants to merge 2 commits intogh/malfet/438/basefrom
gh/malfet/438/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 17, 2025

Stack from ghstack (oldest at bottom):

  • Skip test_index_put_accumulate_large_tensor_mps as it crashes with
/com.apple.xbs/Sources/MetalPerformanceShaders/MPSCore/Types/MPSNDArray.mm:829: failed assertion `[MPSNDArray initWithDevice:descriptor:isTextureBacked:] Error: NDArray dimension length > INT_MAX'

while running torch.ones([2**31+5], dtype=torch.int8, device='mps')

  • Adjust types for test_index_put_src_datatype as index_put on MPS is not implemented for complex (yet)
  • Adjust test_index to avoid using DoubleTensors for MPS

cc @kulinseth @albanD @DenisVieriu97 @jhavukainen

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158582

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 6 Pending, 1 Unrelated Failure

As of commit 02970a3 with merge base d9426a8 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 17, 2025
malfet added a commit that referenced this pull request Jul 17, 2025
And skip `test_index_put_accumulate_large_tensor_mps` as it crashes with
```
/com.apple.xbs/Sources/MetalPerformanceShaders/MPSCore/Types/MPSNDArray.mm:829: failed assertion `[MPSNDArray initWithDevice:descriptor:isTextureBacked:] Error: NDArray dimension length > INT_MAX'
```

ghstack-source-id: e315ce5
Pull Request resolved: #158582
@malfet malfet requested review from dcci and manuelcandales July 17, 2025 18:30
@malfet malfet added the module: mps Related to Apple Metal Performance Shaders framework label Jul 17, 2025
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2025
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jul 17, 2025
And skip `test_index_put_accumulate_large_tensor_mps` as it crashes with
```
/com.apple.xbs/Sources/MetalPerformanceShaders/MPSCore/Types/MPSNDArray.mm:829: failed assertion `[MPSNDArray initWithDevice:descriptor:isTextureBacked:] Error: NDArray dimension length > INT_MAX'
```

ghstack-source-id: fe9c8e5
Pull Request resolved: #158582
@malfet
Copy link
Contributor Author

malfet commented Jul 17, 2025

@pytorchbot merge -f "Lint + trunk tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/438/head branch August 17, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants