Skip to content

Shunt fx_interpreter graphmodule print on error into tlparse#158469

Closed
wconstab wants to merge 2 commits intogh/wconstab/427/basefrom
gh/wconstab/427/head
Closed

Shunt fx_interpreter graphmodule print on error into tlparse#158469
wconstab wants to merge 2 commits intogh/wconstab/427/basefrom
gh/wconstab/427/head

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Jul 16, 2025

Stack from ghstack (oldest at bottom):

Include both the error stacktrace and the graphmodule in a new
structured trace artifact. Log the shortened version to the console,
and also log a hint to look at the tlparse for more.

cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv

Include both the error stacktrace and the graphmodule in a new
structured trace artifact.  Log the shortened version to the console,
and also log a hint to look at the tlparse for more.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158469

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit dabe26c with merge base 900fba4 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Jul 16, 2025
wconstab added a commit that referenced this pull request Jul 16, 2025
Include both the error stacktrace and the graphmodule in a new
structured trace artifact.  Log the shortened version to the console,
and also log a hint to look at the tlparse for more.

ghstack-source-id: 8fdbbab
Pull Request resolved: #158469
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably also check with whoever added this in the first place. Also, the error message is totally not going to help anyone who doesn't already know how to do this. @williamwen42 this is a perfect use case for the website BTW.

@wconstab
Copy link
Contributor Author

I'd probably also check with whoever added this in the first place

Looks like it was @bdhirsh - well, i'll go ahead and land it and when he's back we can confirm and change if needed.

Also, the error message is totally not going to help anyone who doesn't already know how to do this.

I could link to a doc. Would this be the best link for docs? it at least shows usage. i am not sure if we have an official doc page or tutorial that shows this.
https://github.com/pytorch/tlparse?tab=readme-ov-file#tlparse-parse-structured-pt2-logs

@wconstab wconstab added topic: not user facing topic category and removed topic: not user facing topic category labels Jul 17, 2025
Include both the error stacktrace and the graphmodule in a new
structured trace artifact.  Log the shortened version to the console,
and also log a hint to look at the tlparse for more.

cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158481

1 similar comment
@pytorchmergebot
Copy link
Collaborator

Starting merge as part of PR stack under #158481

pytorchmergebot pushed a commit that referenced this pull request Jul 18, 2025
@github-actions github-actions bot deleted the gh/wconstab/427/head branch August 18, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fx Merged release notes: fx release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants