Skip to content

Suppress volatile type error#158435

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:c++20_warning
Closed

Suppress volatile type error#158435
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:c++20_warning

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 16, 2025

Fixes

/var/lib/jenkins/workspace/torch/csrc/dynamo/guards.cpp:5320:10: 
error: compound assignment to object of volatile-qualified type 'volatile char' is deprecated [-Werror,-Wdeprecated-volatile]

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158435

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 35ee457 with merge base 306dd19 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 16, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 16, 2025
@cyyever cyyever changed the title Fix C++20 error Suppress C++20 error Jul 16, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 17, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #158435, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 17, 2025

@pytorchbot rebase -b main

@cyyever cyyever changed the title Suppress C++20 error Suppress volatile type error Jul 17, 2025
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased c++20_warning onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout c++20_warning && git pull --rebase)

Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@janeyx99
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the c++20_warning branch July 21, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants