Skip to content

[BE] Make PyObjectSlot use a global PyInterpreter#158409

Closed
PaliC wants to merge 10 commits intogh/PaliC/17/basefrom
gh/PaliC/17/head
Closed

[BE] Make PyObjectSlot use a global PyInterpreter#158409
PaliC wants to merge 10 commits intogh/PaliC/17/basefrom
gh/PaliC/17/head

Conversation

@PaliC
Copy link
Contributor

@PaliC PaliC commented Jul 16, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158409

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures

As of commit ddf16cc with merge base c66e58b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

PaliC added a commit that referenced this pull request Jul 16, 2025
ghstack-source-id: 7a61ce4
Pull Request resolved: #158409
PaliC added a commit that referenced this pull request Jul 30, 2025
ghstack-source-id: aa7bdce
Pull Request resolved: #158409
PaliC added a commit that referenced this pull request Jul 30, 2025
ghstack-source-id: ecf6d88
Pull Request resolved: #158409
PaliC added a commit that referenced this pull request Jul 30, 2025
ghstack-source-id: 2eab2d1
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 2eab2d1
Pull Request resolved: #159511
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

is_le<sizeof(extra_meta_), 16, FieldNameEnum::extra_meta_>();
are_equal<sizeof(version_counter_), 8, FieldNameEnum::version_counter_>();
are_equal<sizeof(pyobj_slot_), 16, FieldNameEnum::pyobj_slot_>();
are_equal<sizeof(pyobj_slot_), 8, FieldNameEnum::pyobj_slot_>();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: alignment hurrrrttttts

[ghstack-poisoned]
PaliC added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 556291e
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 556291e
Pull Request resolved: #159511
[ghstack-poisoned]
PaliC added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 2884011
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 2884011
Pull Request resolved: #159511
@PaliC
Copy link
Contributor Author

PaliC commented Sep 10, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Sep 10, 2025
ghstack-source-id: 9490e47
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 9490e47
Pull Request resolved: #159511
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/PaliC/17/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/158409)

[ghstack-poisoned]
PaliC added a commit that referenced this pull request Sep 10, 2025
ghstack-source-id: 826f3f0
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 826f3f0
Pull Request resolved: #159511
PaliC added a commit to PaliC/pytorch that referenced this pull request Sep 10, 2025
ghstack-source-id: 826f3f0
Pull Request resolved: pytorch#158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 826f3f0
Pull Request resolved: pytorch#159511
pytorch-bot bot pushed a commit that referenced this pull request Sep 13, 2025
ghstack-source-id: 826f3f0
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 826f3f0
Pull Request resolved: #159511
pytorch-bot bot pushed a commit that referenced this pull request Sep 25, 2025
ghstack-source-id: 826f3f0
Pull Request resolved: #158409

[BE] Remove pyinterpreter struct from pyobjslot

ghstack-source-id: 826f3f0
Pull Request resolved: #159511
Khanaksahu pushed a commit to Khanaksahu/pytorch that referenced this pull request Nov 17, 2025
Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request Nov 18, 2025
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 15, 2025
@github-actions github-actions bot closed this Jan 14, 2026
@github-actions github-actions bot deleted the gh/PaliC/17/head branch February 14, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants