Skip to content

Make triton build ROCm library version-agnostic#158408

Closed
jithunnair-amd wants to merge 1 commit intopytorch:mainfrom
ROCm:make_triton_build_version_agnostic
Closed

Make triton build ROCm library version-agnostic#158408
jithunnair-amd wants to merge 1 commit intopytorch:mainfrom
ROCm:make_triton_build_version_agnostic

Conversation

@jithunnair-amd
Copy link
Collaborator

@jithunnair-amd jithunnair-amd commented Jul 16, 2025

Fixes maintenance of triton packaging script when library versions change from one ROCm version to next.

cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
Co-authored-by: Jithun Nair <37884920+jithunnair-amd@users.noreply.github.com>
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158408

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 0a59d79 with merge base 144965c (image):

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/rocm Trigger "default" config CI on ROCm module: rocm AMD GPU support for Pytorch topic: not user facing topic category labels Jul 16, 2025
@jithunnair-amd jithunnair-amd requested a review from jataylo July 16, 2025 02:40
@jithunnair-amd
Copy link
Collaborator Author

cc @iupaikov-amd

@jithunnair-amd jithunnair-amd changed the title Make triton build ROCm version agnostic Make triton build ROCm library version agnostic Jul 16, 2025
@jithunnair-amd jithunnair-amd changed the title Make triton build ROCm library version agnostic Make triton build ROCm library version-agnostic Jul 16, 2025
@jithunnair-amd jithunnair-amd added ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/triton_binaries labels Jul 16, 2025
@jithunnair-amd
Copy link
Collaborator Author

Triton wheels built successfully: https://github.com/pytorch/pytorch/actions/runs/16330201714 and locally installed and imported successfully.

@jithunnair-amd jithunnair-amd marked this pull request as ready for review August 13, 2025 19:47
@jithunnair-amd jithunnair-amd requested a review from a team as a code owner August 13, 2025 19:47
@jithunnair-amd
Copy link
Collaborator Author

@pytorchbot merge -f "Unrelated CI failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
Fixes maintenance of triton packaging script when library versions change from one ROCm version to next.

Pull Request resolved: #158408
Approved by: https://github.com/jeffdaily

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
Fixes maintenance of triton packaging script when library versions change from one ROCm version to next.

Pull Request resolved: #158408
Approved by: https://github.com/jeffdaily

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
Fixes maintenance of triton packaging script when library versions change from one ROCm version to next.

Pull Request resolved: pytorch#158408
Approved by: https://github.com/jeffdaily

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Fixes maintenance of triton packaging script when library versions change from one ROCm version to next.

Pull Request resolved: pytorch#158408
Approved by: https://github.com/jeffdaily

Co-authored-by: Ethan Wee <Ethan.Wee@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/rocm Trigger "default" config CI on ROCm ciflow/triton_binaries Merged module: rocm AMD GPU support for Pytorch open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants