[BE]Clean up old APIs in AOTI c shim by yiming0416 · Pull Request #158400 · pytorch/pytorch

yiming0416 · 2025-07-15T23:52:54Z

Summary:
The shims for aten ops are now generated by torchgen. But there are some still old APIs in aoti_torch/c/shim.h

This diff moves the old to-be-deprecated APIs for aten ops to a separate header file shim_deprecated.h

The to-be-deprecated APIs are determined by comparing APIs in shim.h and ops in fallback_ops.py

Test Plan:
CI

Rollback Plan:

Differential Revision: D78378373

pytorch-bot · 2025-07-15T23:52:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158400

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 627aabc with merge base 23550ab ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
torchrec_dlrm

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-07-15T23:53:09Z

This pull request was exported from Phabricator. Differential Revision: D78378373

github-actions · 2025-07-15T23:56:46Z

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Differential Revision: D78378373

facebook-github-bot · 2025-07-16T16:36:04Z

This pull request was exported from Phabricator. Differential Revision: D78378373

Summary: Pull Request resolved: pytorch#158400 The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Differential Revision: D78378373

torch/csrc/inductor/aoti_torch/c/shim_deprecated.h

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-16T20:25:21Z

This pull request was exported from Phabricator. Differential Revision: D78378373

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-16T20:49:11Z

This pull request was exported from Phabricator. Differential Revision: D78378373

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-16T21:08:43Z

This pull request was exported from Phabricator. Differential Revision: D78378373

facebook-github-bot · 2025-07-16T21:13:00Z

This pull request was exported from Phabricator. Differential Revision: D78378373

Summary: Pull Request resolved: pytorch#158400 The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: jingsh Differential Revision: D78378373

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-16T21:45:03Z

This pull request was exported from Phabricator. Differential Revision: D78378373

desertfire · 2025-07-16T23:53:15Z

torch/csrc/inductor/aoti_torch/c/shim.h

-);
-
 AOTI_TORCH_EXPORT AOTITorchError
 aoti_torch__scaled_dot_product_flash_attention_v2(


This one needs to be moved as well.

@desertfire I can move it to shim_deprecated.h but I cannot mark it with [[deprecated]]. Otherwise build failed as in shim_common.cpp aoti_torch__scaled_dot_product_flash_attention_v2 is being called inside aoti_torch__scaled_dot_product_flash_attention and all warnings being treated as errors in CI.

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` #buildall Test Plan: CI Rollback Plan: Reviewed By: desertfire, jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-17T00:44:37Z

This pull request was exported from Phabricator. Differential Revision: D78378373

Summary: The shims for aten ops are now generated by torchgen. But there are some still old APIs in `aoti_torch/c/shim.h` This diff moves the old to-be-deprecated APIs for aten ops to a separate header file `shim_deprecated.h` The to-be-deprecated APIs are determined by comparing APIs in `shim.h` and ops in `fallback_ops.py` Test Plan: CI Rollback Plan: Reviewed By: desertfire, jingsh Differential Revision: D78378373

facebook-github-bot · 2025-07-17T16:46:30Z

This pull request was exported from Phabricator. Differential Revision: D78378373

facebook-github-bot · 2025-07-17T23:16:55Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-07-17T23:19:10Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorch-bot bot added ciflow/inductor release notes: inductor (aoti) labels Jul 15, 2025

facebook-github-bot added the fb-exported label Jul 15, 2025

yiming0416 marked this pull request as draft July 15, 2025 23:53

yiming0416 changed the title ~~[WIP][BE]Clean up old APIs in AOTI c shim~~ [BE]Clean up old APIs in AOTI c shim Jul 16, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 16, 2025

yiming0416 marked this pull request as ready for review July 16, 2025 16:26

yiming0416 requested a review from desertfire July 16, 2025 16:26

yiming0416 force-pushed the export-D78378373 branch from ad760d4 to b6e4e07 Compare July 16, 2025 16:28

yiming0416 force-pushed the export-D78378373 branch from b6e4e07 to 1a4398b Compare July 16, 2025 16:36

jingsh approved these changes Jul 16, 2025

View reviewed changes

desertfire reviewed Jul 16, 2025

View reviewed changes

torch/csrc/inductor/aoti_torch/c/shim_deprecated.h Outdated Show resolved Hide resolved

torch/csrc/inductor/aoti_torch/c/shim_deprecated.h Show resolved Hide resolved

torch/csrc/inductor/aoti_torch/c/shim_deprecated.h Show resolved Hide resolved

yiming0416 force-pushed the export-D78378373 branch from 1a4398b to 2ea3cca Compare July 16, 2025 20:25

yiming0416 requested a review from desertfire July 16, 2025 20:28

yiming0416 force-pushed the export-D78378373 branch from 2ea3cca to 0e35052 Compare July 16, 2025 20:48

yiming0416 force-pushed the export-D78378373 branch from 0e35052 to 0165ded Compare July 16, 2025 21:08

yiming0416 force-pushed the export-D78378373 branch from 0165ded to b0cd274 Compare July 16, 2025 21:08

yiming0416 force-pushed the export-D78378373 branch from b0cd274 to f47484c Compare July 16, 2025 21:13

yiming0416 force-pushed the export-D78378373 branch from f47484c to 9a876e0 Compare July 16, 2025 21:44

desertfire approved these changes Jul 16, 2025

View reviewed changes

yiming0416 force-pushed the export-D78378373 branch from 9a876e0 to 381f44b Compare July 17, 2025 00:44

yiming0416 force-pushed the export-D78378373 branch from 381f44b to 627aabc Compare July 17, 2025 16:46

pytorchmergebot added the merging label Jul 17, 2025

pytorchmergebot closed this in f63988a Jul 17, 2025

pytorchmergebot added Merged and removed merging labels Jul 17, 2025

Conversation

yiming0416 commented Jul 15, 2025

Uh oh!

pytorch-bot bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158400

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

facebook-github-bot commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Attention! PyTorch one of the C-stable API file was changed

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

facebook-github-bot commented Jul 16, 2025

Uh oh!

desertfire Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

yiming0416 Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jul 17, 2025

Uh oh!

facebook-github-bot commented Jul 17, 2025

Uh oh!

facebook-github-bot commented Jul 17, 2025

Uh oh!

pytorchmergebot commented Jul 17, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pytorch-bot bot commented Jul 15, 2025 •

edited

Loading