[dynamo][guards] Use version counter to speedup TENSOR_MATCH#158211

Closed

anijain2305 wants to merge 9 commits intogh/anijain2305/812/basefrom

gh/anijain2305/812/head

Contributor

anijain2305 commented Jul 14, 2025 •

edited by pytorch-bot bot

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

1f10544

[ghstack-poisoned]

anijain2305 mentioned this pull request

For discussion #158156

Closed

pytorch-bot bot commented Jul 14, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158211

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 94afad9 with merge base 23550ab ():

NEW FAILURES - The following jobs have failed:

Check Labels / Check labels (gh)
RuntimeError: Error checking labels: PR does not have required labels
inductor / unit-test / cuda12.8-py3.13-gcc9-sm86 / build (gh)
/var/lib/jenkins/workspace/torch/csrc/dynamo/guards.cpp:3691:38: error: invalid conversion from ‘PyObject*’ {aka ‘_object*’} to ‘int’ [-fpermissive]
pull / linux-jammy-py3.13-clang12 / build (gh)
/var/lib/jenkins/workspace/torch/csrc/dynamo/guards.cpp:3691:11: error: cannot initialize a variable of type 'int' with an rvalue of type 'PyObject *' (aka '_object *')

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
torchrec_dlrm

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: dynamo labels

Contributor

github-actions bot commented Jul 14, 2025

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

anijain2305 mentioned this pull request

[dynamo][guards] Instruction count for guard eval for development work #158214

Closed


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

080ec54

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 mentioned this pull request

[dynamo][tensor] Skip HASATTR attribute on tensor guards #158215

Closed


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

290a459

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

a136107

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

4eb05f9

ghstack-source-id: e35a925
Pull Request resolved: #158211


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

651b89b

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 mentioned this pull request

[easy][guards] Add developer comment for posterity #158471

Closed

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

8f9da7f

ghstack-source-id: b4cabb8
Pull Request resolved: #158211


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

4c7805c

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

d0115b5

ghstack-source-id: 37fbeaa
Pull Request resolved: #158211


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

4a505e5

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 mentioned this pull request

[dynamo] Skip training flag check id already guarding on nn modules #158492

Closed

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

2307e53

ghstack-source-id: 1520866
Pull Request resolved: #158211


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

d132db3

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

f0dc537

ghstack-source-id: 9419d73
Pull Request resolved: #158211


          Update on "[dynamo][guards] Use version counter to speedup TENSOR_MATCH"

94afad9

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]

anijain2305 added a commit that referenced this pull request


          [dynamo][guards] Use version counter to speedup TENSOR_MATCH

96bf99d

ghstack-source-id: 27de299
Pull Request resolved: #158211

Contributor

github-actions bot commented Sep 15, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the Stale label

github-actions bot closed this

github-actions bot deleted the gh/anijain2305/812/head branch

November 15, 2025 02:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor module: dynamo Stale