Skip to content

fix MPCT destroy_pg call#157952

Closed
H-Huang wants to merge 1 commit intogh/H-Huang/194/basefrom
gh/H-Huang/194/head
Closed

fix MPCT destroy_pg call#157952
H-Huang wants to merge 1 commit intogh/H-Huang/194/basefrom
gh/H-Huang/194/head

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Jul 9, 2025

Stack from ghstack (oldest at bottom):

I was seeing hangs / exceptions not raising in some cases. Only call c10d.destroy_process_group() for MultiProcessContinuousTest in the clean exit case.

cc @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157952

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 81b4350 with merge base 0105cd8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jul 9, 2025
@H-Huang H-Huang requested review from kwen2501 and wconstab July 9, 2025 18:47
@H-Huang H-Huang added the topic: not user facing topic category label Jul 9, 2025
@H-Huang H-Huang requested a review from fduwjj July 10, 2025 15:15
@H-Huang
Copy link
Member Author

H-Huang commented Jul 11, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 11, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/H-Huang/194/head branch August 11, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants