Skip to content

remove allow-untyped-defs from torch/ao/nn/intrinsic/quantized/dynamic/modules/linear_relu.py#157848

Closed
bobrenjc93 wants to merge 2 commits intogh/bobrenjc93/524/basefrom
gh/bobrenjc93/524/head
Closed

remove allow-untyped-defs from torch/ao/nn/intrinsic/quantized/dynamic/modules/linear_relu.py#157848
bobrenjc93 wants to merge 2 commits intogh/bobrenjc93/524/basefrom
gh/bobrenjc93/524/head

Conversation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157848

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Cancelled Jobs

As of commit 4811c59 with merge base 8134684 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
"""

_FLOAT_MODULE = nni.LinearReLU # type: ignore[assignment]
_FLOAT_MODULE = nni.LinearReLU
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this should actually be a ClassVar as annoying as that is to annoated properlty here:

Suggested change
_FLOAT_MODULE = nni.LinearReLU
_FLOAT_MODULE : ClassVar[Type[nni.LinearReLU]] = nni.LinearReLU

@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Jul 9, 2025
@bobrenjc93 bobrenjc93 marked this pull request as ready for review July 9, 2025 22:54
@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@Skylion007
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.2), trunk / linux-jammy-rocm-py3.10 / test (default, 2, 2, linux.rocm.gpu.2)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/bobrenjc93/524/head branch August 12, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: AO frontend topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants