Skip to content

[CI][MacOS] Add VENV_PATH to search path#157749

Closed
malfet wants to merge 2 commits intogh/malfet/430/basefrom
gh/malfet/430/head
Closed

[CI][MacOS] Add VENV_PATH to search path#157749
malfet wants to merge 2 commits intogh/malfet/430/basefrom
gh/malfet/430/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jul 7, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

When building/testing PyTorch on MacOS

Shoudl prevent some flakiness when conda environment overtakes CI/CD

@malfet
Update
18b22c2 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner July 7, 2025 23:54
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157749

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job, 38 Pending

As of commit d56746e with merge base 510c398 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

  • Lint / toc / linux-job (gh)
    The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jul 7, 2025
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2025
@malfet
Copy link
Contributor Author

malfet commented Jul 8, 2025

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Jul 8, 2025

@pytorchbot revert -m 'It looks like lint was not green, so revert and reland I guess' -c ignoredsignal

GH job link HUD commit link

@pytorch pytorch deleted a comment from pytorch-bot bot Jul 8, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 8, 2025
@pytorchmergebot
Revert "[CI][MacOS] Add VENV_PATH to search path (#157749)"
30a1cc1 
This reverts commit 85111cd.

Reverted #157749 on behalf of https://github.com/huydhn due to It looks like lint was not green, so revert and reland I guess ([comment](#157749 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

@malfet your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 8, 2025
@malfet
Update
d56746e 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Jul 8, 2025
@malfet
[CI][MacOS] Add VENV_PATH to search path
eda6903 
When building/testing PyTorch on MacOS

Shoudl prevent some flakiness when conda environment overtakes CI/CD

ghstack-source-id: aa652e3
Pull Request resolved: #157749
@malfet
Copy link
Contributor Author

malfet commented Jul 8, 2025

@pytorchbot merge -f "Lint is good now?"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/430/head branch August 8, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@atalman atalman atalman approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/pull ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted test-config/default topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @huydhn @atalman