[EZ][BE] Move array def to c10/metal/common.h#157746
Closed
malfet wants to merge 2 commits intogh/malfet/429/basefrom
Closed
[EZ][BE] Move array def to c10/metal/common.h#157746malfet wants to merge 2 commits intogh/malfet/429/basefrom
c10/metal/common.h#157746malfet wants to merge 2 commits intogh/malfet/429/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157746
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c8187ce with merge base 510c398 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
approved these changes
Jul 8, 2025
dcci
approved these changes
Jul 8, 2025
Collaborator
|
Starting merge as part of PR stack under #157751 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 8, 2025
Instead of every shader defining it separately, move it to `c10/metal/common.h` Pull Request resolved: #157751 Approved by: https://github.com/Skylion007, https://github.com/dcci ghstack dependencies: #157746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
simdgroup_sizeconstexpr #157751c10/metal/common.h#157746And use proper type aliasing instead of weird _ARRAY_NS
Also use
uint64_tinstead ofulong