[BE] add `SHFMT` linter to format shell scripts by XuehaiPan · Pull Request #157685 · pytorch/pytorch

XuehaiPan · 2025-07-07T02:40:28Z

Stack from ghstack (oldest at bottom):

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @seemethere @malfet @pytorch/pytorch-dev-infra @albanD @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @ZainRizvi @huydhn @clee2000

[ghstack-poisoned]

pytorch-bot · 2025-07-07T02:40:31Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157685

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 2 Unrelated Failures

As of commit cebe69d with merge base 9aedb3c ():

NEW FAILURES - The following jobs have failed:

linux-s390x-binary-manywheel / manywheel-py3_10-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_11-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_12-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_13-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_13t-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_14-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'
linux-s390x-binary-manywheel / manywheel-py3_14t-cpu-s390x-build / build (gh)
undefined reference to 'dlclose'

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (similar failure)
test_nestedtensor.py::TestNestedTensorSubclassCUDA::test_flex_attention_noncontig_with_holes_False_cross_attention_False_cuda_float32

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 5, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (trunk failure)
test_nestedtensor.py::TestNestedTensorSubclassCUDA::test_flex_attention_converts_stacked_seq_indices_cuda_float32

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

ghstack-source-id: 8205ece Pull-Request: pytorch#157685

Skylion007 · 2025-07-07T12:35:11Z

Do we have shellcheck enabled? If not, may be a less intrusive check to start with.

XuehaiPan · 2025-07-07T13:14:36Z

Do we have shellcheck enabled?

No.

[ghstack-poisoned]

ghstack-source-id: e9067f1 Pull-Request: pytorch#157685

seemethere · 2025-07-08T14:40:56Z

Do we have shellcheck enabled?

No.

I actually do believe we have shellcheck enabled, it's just over a smaller subset of things:

pytorch/.lintrunner.toml

Lines 886 to 905 in 86670b3

    
           [[linter]] 
        
           code = 'SHELLCHECK' 
        
           include_patterns = [ 
        
               '.ci/pytorch/**/*.sh' 
        
           ] 
        
           exclude_patterns = [ 
        
               '**/fb/**', 
        
           ] 
        
           command = [ 
        
               'python3', 
        
               'tools/linter/adapters/shellcheck_linter.py', 
        
               '--', 
        
               '@{{PATHSFILE}}', 
        
           ] 
        
           init_command = [ 
        
               'python3', 
        
               'tools/linter/adapters/pip_init.py', 
        
               '--dry-run={{DRYRUN}}', 
        
               'shellcheck-py==0.7.2.1', 
        
           ]

What's the benefit here of shfmt over just enabling shellcheck everywhere else?

XuehaiPan · 2025-07-08T15:44:40Z

I actually do believe we have shellcheck enabled, it's just over a smaller subset of things:

Thanks for the clarification.

What's the benefit here of shfmt over just enabling shellcheck everywhere else?

It's a formatter to standardize the style for shell scripts and prevent potential merge conflicts like PYFMT for Python code.

FYI, shellcheck --format=diff provides an autofix feature.

ghstack-source-id: e9067f1 Pull-Request: pytorch#157685

[ghstack-poisoned]

ghstack-source-id: 44f28ab Pull-Request: pytorch#157685

[ghstack-poisoned]

ghstack-source-id: 95f930a Pull-Request: pytorch#157685

[ghstack-poisoned]

ghstack-source-id: 7fe0193 Pull-Request: pytorch#157685

[ghstack-poisoned]

ghstack-source-id: 6547e7e Pull-Request: pytorch#157685

[ghstack-poisoned]

ghstack-source-id: ce4d210 Pull-Request: pytorch#157685

Update

b30f402

[ghstack-poisoned]

XuehaiPan requested review from a team, digantdesai, jeffdaily, jerryzh168, jianyuh, kimishpatel and salilsdesai as code owners July 7, 2025 02:40

pytorch-bot bot added ciflow/inductor module: cpu CPU specific problem (e.g., perf, algorithm) module: dynamo release notes: quantization release notes category release notes: releng release notes category labels Jul 7, 2025

facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Jul 7, 2025

XuehaiPan requested review from atalman and malfet July 7, 2025 02:41

pytorchbot added the open source label Jul 7, 2025

Update

bb15785

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 7, 2025

[BE][4/4] format shell scripts with SHFMT in scripts/ #157689

Closed

Update

3bdccb5

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 7, 2025

[BE] add SHFMT linter to format shell scripts

1e3b759

ghstack-source-id: 8205ece Pull-Request: pytorch#157685

Update

c248096

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 8, 2025

[BE] add SHFMT linter to format shell scripts

03321e8

ghstack-source-id: e9067f1 Pull-Request: pytorch#157685

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 9, 2025

[BE] add SHFMT linter to format shell scripts

76b4022

ghstack-source-id: e9067f1 Pull-Request: pytorch#157685

Update

ad32fe5

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 12, 2025

[BE] add SHFMT linter to format shell scripts

312d2bf

ghstack-source-id: 44f28ab Pull-Request: pytorch#157685

Update

108209f

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 15, 2025

[BE] add SHFMT linter to format shell scripts

6c2bc7c

ghstack-source-id: 95f930a Pull-Request: pytorch#157685

Update

5a5a4ea

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 21, 2025

[BE] add SHFMT linter to format shell scripts

5f88296

ghstack-source-id: 7fe0193 Pull-Request: pytorch#157685

Update

f3965ab

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Aug 10, 2025

[BE] add SHFMT linter to format shell scripts

fc740db

ghstack-source-id: 6547e7e Pull-Request: pytorch#157685

Update

cebe69d

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Sep 6, 2025

[BE] add SHFMT linter to format shell scripts

734e7a2

ghstack-source-id: ce4d210 Pull-Request: pytorch#157685

XuehaiPan closed this Oct 30, 2025

github-actions bot deleted the gh/XuehaiPan/356/head branch November 30, 2025 02:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE] add `SHFMT` linter to format shell scripts#157685

[BE] add `SHFMT` linter to format shell scripts#157685
XuehaiPan wants to merge 9 commits intogh/XuehaiPan/356/basefrom
gh/XuehaiPan/356/head

XuehaiPan commented Jul 7, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

Skylion007 commented Jul 7, 2025

Uh oh!

XuehaiPan commented Jul 7, 2025

Uh oh!

seemethere commented Jul 8, 2025

Uh oh!

XuehaiPan commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

XuehaiPan commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157685

❌ 7 New Failures, 2 Unrelated Failures

Uh oh!

Skylion007 commented Jul 7, 2025

Uh oh!

XuehaiPan commented Jul 7, 2025

Uh oh!

seemethere commented Jul 8, 2025

Uh oh!

XuehaiPan commented Jul 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

XuehaiPan commented Jul 7, 2025 •

edited

Loading

pytorch-bot bot commented Jul 7, 2025 •

edited

Loading