[pc] migrate progression futures from list to deque#157614
Closed
bobrenjc93 wants to merge 4 commits intogh/bobrenjc93/511/basefrom
Closed
[pc] migrate progression futures from list to deque#157614bobrenjc93 wants to merge 4 commits intogh/bobrenjc93/511/basefrom
bobrenjc93 wants to merge 4 commits intogh/bobrenjc93/511/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157614
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit be05e6c with merge base c808af5 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 4, 2025
aorenste
approved these changes
Jul 4, 2025
| self._fast_output_code = fast_output_code | ||
| self._optimized_output_code = None | ||
| self._progression_futures = list(progression_futures) | ||
| self._progression_futures = deque(progression_futures) |
Contributor
There was a problem hiding this comment.
nit: Above (github won't let me comment on unchanged lines):
progression_futures: Sequence[Future[_WireProtocolPickledOutput]],
Contributor
Author
There was a problem hiding this comment.
Problem is then mypy complains about no popleft
Error (MYPY) [attr-defined]
"Sequence[Future[_WireProtocolPickledOutput]]" has no attribute "popleft"
268 |
269 | # Clear earlier progression futures to free memory
270 | for _ in range(stage_index + 1):
>>> 271 | self._progression_futures.popleft()
272 |
273 | @override
274 | def post_compile(
Contributor
There was a problem hiding this comment.
I think you misunderstood. I meant the init signature should take Sequence. The instance member should still be deque. (I can see that what I wrote wasn't clear)
Collaborator
|
Starting merge as part of PR stack under #157650 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 5, 2025
Pull Request resolved: #157650 Approved by: https://github.com/aorenste ghstack dependencies: #157305, #157614, #157619
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov