[BE] fix typo: inpt -> input#157361
Closed
XuehaiPan wants to merge 9 commits intogh/XuehaiPan/341/basefrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157361
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 049436a with merge base 38757d9 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 1, 2025
This was referenced Jul 1, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 1, 2025
ghstack-source-id: c6ff163 Pull-Request: pytorch#157361
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 2, 2025
ghstack-source-id: f0e2888 Pull-Request: pytorch#157361
This was referenced Jul 3, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 3, 2025
ghstack-source-id: bdc9c23 Pull-Request: pytorch#157361
This was referenced Jul 4, 2025
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 4, 2025
ghstack-source-id: 05baa64 Pull-Request: pytorch#157361
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 6, 2025
ghstack-source-id: ce1e5b5 Pull-Request: pytorch#157361
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jul 8, 2025
ghstack-source-id: 208db5d Pull-Request: pytorch#157361
albanD
requested changes
Jul 8, 2025
Collaborator
albanD
left a comment
There was a problem hiding this comment.
Why change all of this code? inpt is very valid for variable names
Contributor
|
And in fact, it is typically to avoid shadowing input |
Collaborator
Author
|
Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov