Skip to content

Update pr_time_benchmarks expected results#157214

Closed
jansel wants to merge 2 commits intogh/jansel/528/basefrom
gh/jansel/528/head
Closed

Update pr_time_benchmarks expected results#157214
jansel wants to merge 2 commits intogh/jansel/528/basefrom
gh/jansel/528/head

Conversation

@jansel
Copy link
Contributor

@jansel jansel commented Jun 29, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157214

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 5 Pending, 2 Unrelated Failures

As of commit 2fedd18 with merge base bccb847 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jansel jansel requested a review from laithsakka June 29, 2025 05:47
@jansel jansel added the topic: not user facing topic category label Jun 29, 2025
@jansel
Copy link
Contributor Author

jansel commented Jun 29, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/jansel/528/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/157214)

pytorchmergebot pushed a commit that referenced this pull request Jun 29, 2025
The job has been unstable


ghstack-source-id: 30c46b3
Pull-Request: #157214
@laithsakka
Copy link
Contributor

laithsakka commented Jun 29, 2025

@pytorchbot merge --force " pr time benchmark job succeeded only effected test"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@laithsakka
Copy link
Contributor

laithsakka commented Jun 29, 2025

seems like it mainly failing due to win on symint_sum
addressed in this PR

I think maybe we need to split each benchmark into its own test this way only symint_sum would fail and others would succeed. @huydhn what do you think of this idea.

@huydhn
Copy link
Contributor

huydhn commented Jul 8, 2025

I think that only makes sense if:

  1. you want to move symint_sum to a separate workflow that doesn't block merge
  2. and symint_sum is the only one causing troubles

Generally, I would prefer to have a way for oncall to quickly disable the failing benchmark, so that it can be dealt with later without affecting others:

  1. In the short term, maybe having a JSON file to include something like { "symint_sum": "skip" }
  2. If more benchmarks are coming in the future, building a similar mechanism to disable a benchmark on CI via an issue like DISABLED test_non_contiguous_input_mm_plus_mm (__main__.TestMaxAutotune) #126867 is probably a good idea

@github-actions github-actions bot deleted the gh/jansel/528/head branch August 7, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants