increment pending_callbacks_counter before initation the pt2 compile callbacks#157185
increment pending_callbacks_counter before initation the pt2 compile callbacks#157185burak-turk wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157185
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5689698 with merge base 41f6ace ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D77475650 |
9ef9fe7 to
a5b3735
Compare
… callbacks (pytorch#157185) Summary: Since we increment the counter after performing the callback, it leads to the assertion error when callback raises an error and increment never happens. Let's increment first to avoid it. Test Plan: tba Rollback Plan: Reviewed By: xmfan Differential Revision: D77475650
|
This pull request was exported from Phabricator. Differential Revision: D77475650 |
a5b3735 to
d9b4259
Compare
… callbacks (pytorch#157185) Summary: Pull Request resolved: pytorch#157185 Since we increment the counter after performing the callback, it leads to the assertion error when callback raises an error and increment never happens. Let's increment first to avoid it. Test Plan: tba Rollback Plan: Reviewed By: xmfan Differential Revision: D77475650
|
This pull request was exported from Phabricator. Differential Revision: D77475650 |
d9b4259 to
5689698
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: Since we increment the counter after performing the callback, it leads to the assertion error when callback raises an error and increment never happens. Let's increment first to avoid it.
Test Plan:
tba
Rollback Plan:
Differential Revision: D77475650
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames