Skip to content

[nativert] hook up memory planning to execution frame#157053

Closed
dolpm wants to merge 1 commit intopytorch:mainfrom
dolpm:export-D73635809
Closed

[nativert] hook up memory planning to execution frame#157053
dolpm wants to merge 1 commit intopytorch:mainfrom
dolpm:export-D73635809

Conversation

@dolpm
Copy link
Copy Markdown
Contributor

@dolpm dolpm commented Jun 27, 2025

Summary: pretty simple. if planner exists, which implies that planning is enabled, create a manager for each frame. the associated serial executor will use the withMemoryPlannner fn to ensure the deallocation is done after execution completes.

Test Plan: CI

Differential Revision: D73635809

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157053

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit 6ac419a with merge base 61712e6 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from bd4d0af to f995fc7 Compare June 27, 2025 05:01
@dolpm dolpm added the topic: not user facing topic category label Jun 27, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from f995fc7 to 81ef5e4 Compare June 27, 2025 05:05
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from 81ef5e4 to 2149e68 Compare June 27, 2025 05:06
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from 2149e68 to e250896 Compare June 27, 2025 05:10
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from e250896 to e8137ef Compare June 27, 2025 16:35
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from e8137ef to 28bd7a1 Compare June 27, 2025 16:41
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm changed the title [sigmoid] hook up memory planning to execution frame [nativert] hook up memory planning to execution frame Jun 27, 2025
@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 27, 2025
@dolpm dolpm force-pushed the export-D73635809 branch from 28bd7a1 to 4093e60 Compare June 27, 2025 18:48
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from 4093e60 to 20f663a Compare June 27, 2025 19:53
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm requested a review from zhxchen17 June 27, 2025 19:56
@dolpm dolpm force-pushed the export-D73635809 branch from 20f663a to a777078 Compare June 27, 2025 20:53
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from a777078 to 91526ee Compare June 27, 2025 21:48
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 27, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from 91526ee to 0ece795 Compare June 28, 2025 00:22
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 28, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm
[sigmoid] hook up memory planning to execution frame (pytorch#157053)
6ac419a 
Summary:
Pull Request resolved: pytorch#157053

pretty simple. if planner exists, which implies that planning is enabled, create a manager for each frame. the associated serial executor will use the withMemoryPlannner fn to ensure the deallocation is done after execution completes.

Test Plan:
CI

Rollback Plan:

Reviewed By: henryoier

Differential Revision: D73635809
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 28, 2025

This pull request was exported from Phabricator. Differential Revision: D73635809

@dolpm dolpm force-pushed the export-D73635809 branch from 0ece795 to 6ac419a Compare June 28, 2025 00:28
dolpm added a commit to dolpm/pytorch that referenced this pull request Jun 28, 2025
@dolpm
[sigmoid] hook up memory planning to execution frame (pytorch#157053)
26a58db 
Summary:
Pull Request resolved: pytorch#157053

pretty simple. if planner exists, which implies that planning is enabled, create a manager for each frame. the associated serial executor will use the withMemoryPlannner fn to ensure the deallocation is done after execution completes.

Test Plan: CI

Differential Revision: D73635809
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jun 29, 2025

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 30, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), Lint / lintrunner-noclang / linux-job

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@henryoier henryoier henryoier approved these changes

@georgiaphillips georgiaphillips georgiaphillips approved these changes

@zhxchen17 zhxchen17 Awaiting requested review from zhxchen17

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dolpm @facebook-github-bot @pytorchmergebot @henryoier @georgiaphillips