[struct] Add struct.pack and struct.unpack polyfills#156977
Closed
guilhermeleobas wants to merge 6 commits intogh/guilhermeleobas/190/basefrom
Closed
[struct] Add struct.pack and struct.unpack polyfills#156977guilhermeleobas wants to merge 6 commits intogh/guilhermeleobas/190/basefrom
struct.pack and struct.unpack polyfills#156977guilhermeleobas wants to merge 6 commits intogh/guilhermeleobas/190/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156977
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b578fe9 with merge base 1b772de ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 26, 2025
XuehaiPan
approved these changes
Jul 9, 2025
jansel
approved these changes
Jul 9, 2025
XuehaiPan
reviewed
Jul 10, 2025
XuehaiPan
reviewed
Jul 10, 2025
torch/_dynamo/polyfills/struct.py
Outdated
|
|
||
|
|
||
| @substitute_in_graph(struct.pack, can_constant_fold_through=True) # type: ignore[arg-type] | ||
| def pack(fmt: Union[bytes, str], /, *v: Any) -> bytes: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def pack(fmt: Union[bytes, str], /, *v: Any) -> bytes: | |
| def pack(fmt: str | bytes, /, *v: Any) -> bytes: |
XuehaiPan
reviewed
Jul 10, 2025
XuehaiPan
reviewed
Jul 22, 2025
Collaborator
|
Starting merge as part of PR stack under #156976 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 23, 2025
Pull Request resolved: #156976 Approved by: https://github.com/zou3519 ghstack dependencies: #156975, #156977
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
float.fromhex#156976struct.packandstruct.unpackpolyfills #156977cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela