Skip to content

Uninstall brew miniconda while running MacOS testing#156898

Closed
malfet wants to merge 1 commit intomainfrom
malfet-patch-13
Closed

Uninstall brew miniconda while running MacOS testing#156898
malfet wants to merge 1 commit intomainfrom
malfet-patch-13

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jun 25, 2025

That results in torch.compile being unable to produce working artifacts
But reinstall it later, when done

Should fix #156833

@malfet malfet requested a review from a team as a code owner June 25, 2025 22:49
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156898

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 654b9fe with merge base dea4864 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 25, 2025
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request ciflow/mps Run MPS tests (subset of trunk) labels Jun 25, 2025
@malfet
Copy link
Contributor Author

malfet commented Jun 26, 2025

@pytorchbot merge -f "All that I care about is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Jul 3, 2025

@pytorchbot cherry-pick --onto release/2.8 -c critical

pytorchbot pushed a commit that referenced this pull request Jul 3, 2025
That results in torch.compile being unable to produce working artifacts

Should fix #156833

Pull Request resolved: #156898
Approved by: https://github.com/seemethere, https://github.com/atalman

(cherry picked from commit 214e295)
@pytorchbot
Copy link
Collaborator

Cherry picking #156898

The cherry pick PR is at #157567 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Jul 4, 2025
Cleanup leftover miniconda brew installation (#156898)

That results in torch.compile being unable to produce working artifacts

Should fix #156833

Pull Request resolved: #156898
Approved by: https://github.com/seemethere, https://github.com/atalman

(cherry picked from commit 214e295)

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@malfet
Copy link
Contributor Author

malfet commented Jul 8, 2025

@pytorchbot revert -m "Breaks TorchVision builds" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jul 8, 2025
This reverts commit 214e295.

Reverted #156898 on behalf of https://github.com/malfet due to Breaks TorchVision builds ([comment](#156898 (comment)))
@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jul 8, 2025
That results in torch.compile being unable to produce working artifacts

Should fix #156833
@malfet malfet force-pushed the malfet-patch-13 branch from 8758e2f to 654b9fe Compare July 8, 2025 18:57
@malfet malfet changed the title Cleanup leftover miniconda brew installation Uninstall brew miniconda while running MacOS testing Jul 8, 2025
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@malfet
Copy link
Contributor Author

malfet commented Jul 9, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor

atalman commented Jul 15, 2025

Seeing following error during reinstall step:
Screenshot 2025-07-15 at 11 43 49 AM

And more failures on torchcodec: https://github.com/pytorch/torchcodec/actions/runs/16288997377/job/45994293742

pytorchmergebot pushed a commit that referenced this pull request Jul 15, 2025
Use ```brew install --cask miniconda``` as specified by https://formulae.brew.sh/cask/miniconda

Forward fix After: #156898 (comment)

Seeing in CI:
```
Run if [[ -n "$REINSTALL_BREW_MINICONDA" ]]; then
==> Caveats
Please run the following to setup your shell:
  conda init "$(basename "${SHELL}")"

Alternatively, manually add the following to your shell init:
  eval "$(conda "shell.$(basename "${SHELL}")" hook)"

==> Downloading https://repo.anaconda.com/miniconda/Miniconda3-py313_25.5.1-0-MacOSX-arm64.sh
Already downloaded: /Users/ec2-user/Library/Caches/Homebrew/downloads/2e356e8b147647692e4da77ce4c0c14eefee65ec86f29cc7e8c21a26ac9397ca--Miniconda3-py313_25.5.1-0-MacOSX-arm64.sh
==> Installing Cask miniconda
==> Running installer script 'Miniconda3-py313_25.5.1-0-MacOSX-arm64.sh'
PREFIX=/opt/homebrew/Caskroom/miniconda/base
Unpacking payload ...
entry_point.py:256: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.
entry_point.py:256: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.

Installing base environment...

Preparing transaction: ...working... done
Executing transaction: ...working...
done
entry_point.py:256: DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.
installation finished.
==> Linking Binary 'conda' to '/opt/homebrew/bin/conda'
🍺  miniconda was successfully installed!
```
Pull Request resolved: #158347
Approved by: https://github.com/seemethere
@github-actions github-actions bot deleted the malfet-patch-13 branch August 15, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UNSTABLE trunk / macos-py3-arm64 / test (mps)

5 participants