Skip to content

Use CMake wholearchive group#156393

Closed
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:use_whole_archive
Closed

Use CMake wholearchive group#156393
cyyever wants to merge 2 commits intopytorch:mainfrom
cyyever:use_whole_archive

Conversation

@cyyever
Copy link
Collaborator

@cyyever cyyever commented Jun 19, 2025 •
edited by pytorch-bot bot
Loading

Use CMake wholearchive group to simplify code. It may also support more OSes.

cc @jeromean @bsochack @sujoysaraswati

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 19, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156393

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit bff37fe with merge base 39a8f66 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Use wholearchive Use CMake wholearchive group Jun 19, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 19, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 19, 2025
@cyyever cyyever requested a review from ngimel June 19, 2025 03:39
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 21, 2025
@cyyever cyyever requested a review from ezyang June 21, 2025 01:54
ezyang
ezyang previously approved these changes Jun 23, 2025
View reviewed changes
@ezyang
Copy link
Contributor

ezyang commented Jun 23, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 23, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@chuanqi129
Copy link
Collaborator

chuanqi129 commented Jun 23, 2025

Hi @cyyever, this change broken XPU Windows build https://github.com/pytorch/pytorch/actions/runs/15818738747/job/44582787726?pr=156572#step:11:1127. Can we revert this change firstly? And this PR's change related to XPU, please help to add ciflow/xpu when we try to re-landing this PR. Thanks.

cc: @ezyang @etaf

etaf
etaf reviewed Jun 23, 2025
View reviewed changes
@etaf
Copy link
Collaborator

etaf commented Jun 23, 2025

Sorry for reverting this PR as commented above.
@pytorchbot revert -m "This PR is breaking XPU windows build." -c nosignal

@etaf etaf added the ciflow/xpu Run XPU CI tasks label Jun 23, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 23, 2025

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Jun 23, 2025
@pytorchmergebot
Revert "Use CMake wholearchive group (#156393)"
4f70fbb 
This reverts commit d1b4e0f.

Reverted #156393 on behalf of https://github.com/etaf due to This PR is breaking XPU windows build. ([comment](#156393 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 23, 2025

@cyyever your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Jun 23, 2025
@cyyever
Copy link
Collaborator Author

cyyever commented Jun 23, 2025

Let me check.

@cyyever
Copy link
Collaborator Author

cyyever commented Jun 23, 2025

@pytorchbot merge

@malfet malfet dismissed ezyang’s stale review June 23, 2025 14:27

This PR broke windows, let's figure out why it was not caught by CI

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 5, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 5, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: xpu / linux-jammy-xpu-2025.0-py3.9 / build

Details for Dev Infra team Raised by workflow job

EikanWang
EikanWang reviewed Jul 7, 2025
View reviewed changes
EikanWang
EikanWang previously requested changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@EikanWang EikanWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the CMake document and cannot find out that the wholearchive can resolve dependencies automatically. https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_LINK_LIBRARY_USING_FEATURE.html#predefined-features

@cyyever , it would be appreciated if you could share the doc with us so that we could analyze CI failures.

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 7, 2025 •
edited
Loading

@EikanWang Sorry, I just found that a key commit was lost due to reopen and rebase, I have added it back.

@cyyever cyyever requested a review from EikanWang July 7, 2025 09:03
@cyyever
Copy link
Collaborator Author

cyyever commented Jul 7, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 7, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 7, 2025

Successfully rebased use_whole_archive onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout use_whole_archive && git pull --rebase)

@ezyang
Copy link
Contributor

ezyang commented Jul 8, 2025

and now xpu broken again. unsubbing for now

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 8, 2025

Although they are unrelated:

 ModuleNotFoundError: No module named 'boto3'

We should wait them for being fixed.

@etaf
Copy link
Collaborator

etaf commented Jul 8, 2025 •
edited
Loading

ModuleNotFoundError: No module named 'boto3' has been fixed in main branch.
@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

Successfully rebased use_whole_archive onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout use_whole_archive && git pull --rebase)

@etaf
Copy link
Collaborator

etaf commented Jul 8, 2025

@cyyever CI is green now.

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 8, 2025

@pytorchmergebot merge -i

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

This PR has pending changes requested. Please address the comments and update the PR before merging.

@cyyever cyyever dismissed EikanWang’s stale review July 8, 2025 12:12

Missing commit has been added back. Now CI passes

@cyyever
Copy link
Collaborator Author

cyyever commented Jul 8, 2025

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 8, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2022-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever deleted the use_whole_archive branch October 2, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etaf etaf etaf left review comments

@ezyang ezyang ezyang approved these changes

@ngimel ngimel Awaiting requested review from ngimel

@EikanWang EikanWang Awaiting requested review from EikanWang

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: hpu Issues related to the hpu device (Habana/Gaudi) open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cyyever @ezyang @pytorchmergebot @chuanqi129 @etaf @jeromean @EikanWang @jerryzh168 @pytorchbot