[TSAN][live speech translation] Fix A data race in caffe2#156378
[TSAN][live speech translation] Fix A data race in caffe2#156378Polyomino wants to merge 1 commit intopytorch:mainfrom
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @Polyomino, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156378
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Cancelled JobsAs of commit 49d23ab with merge base 9fe2d15 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
|
/easycla |
|
can you fix failed tests? |
4f6cdd9 to
53b4a7a
Compare
53b4a7a to
e379d7b
Compare
e379d7b to
16b108d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
16b108d to
bc8a932
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
bc8a932 to
a75cc6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
a75cc6e to
08e07c1
Compare
|
/easycla |
|
@pytorchbot label "topic: not user facing" |
08e07c1 to
c498ab9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
33c790c to
54dd18a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
e6f6c84 to
1453803
Compare
…6378) Summary: noticed that context quantized_engine is accessed and written from multiple threads Pull Request resolved: pytorch#156378 Test Plan: ➜ fbsource buck test --flagfile fbcode/mode/dev-tsan //xplat/assistant/integration_test/tests/supernova/speechtranslation:live_speech_translation_en_fr_tests -- --exact 'fbsource//xplat/assistant/integration_test/tests/supernova/speechtranslation:live_speech_translation_en_fr_tests - Translate/LiveSpeechTranslationTests.LiveSpeechTranslationEnFr/silence___fr_en' Rollback Plan: Rollback Plan: Reviewed By: jerryzh168 Differential Revision: D76921416 Pulled By: Polyomino
|
This pull request was exported from Phabricator. Differential Revision: D76921416 |
1453803 to
49d23ab
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / cuda12.8-py3.10-gcc9-sm80 / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: trunk / cuda12.8-py3.10-gcc9-sm80 / build, trunk / linux-jammy-rocm-py3.10 / test (default, 2, 2, linux.rocm.gpu.2) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: noticed that context quantized_engine is accessed and written from multiple threads
Test Plan:
➜ fbsource buck test --flagfile fbcode/mode/dev-tsan //xplat/assistant/integration_test/tests/supernova/speechtranslation:live_speech_translation_en_fr_tests -- --exact 'fbsource//xplat/assistant/integration_test/tests/supernova/speechtranslation:live_speech_translation_en_fr_tests - Translate/LiveSpeechTranslationTests.LiveSpeechTranslationEnFr/silence___fr_en'
Rollback Plan:
Differential Revision: D76921416