[MPS] Add nearest_3d forward and backward#156090
[MPS] Add nearest_3d forward and backward#156090malfet wants to merge 12 commits intogh/malfet/408/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156090
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f586dce with merge base 32c1611 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
Attention! PyTorch one of the C-stable API file was changedYou MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function. Caused by: |
|
@pytorchbot merge -f "All is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
But only forward for now Pull Request resolved: #156263 Approved by: https://github.com/dcci ghstack dependencies: #156256, #156090
Stack from ghstack (oldest at bottom):
Introduce generalizable
UpsampleParamsstructure inUpSample.h, which could be shared between CPU and MPSDelete
upsample_nearest3dMPS fallback and replace it with proper shader