[VibeCoding] Convert architecture specific batch scripts to PowerShell#155807
Closed
malfet wants to merge 6 commits intogh/malfet/398/basefrom
Closed
[VibeCoding] Convert architecture specific batch scripts to PowerShell#155807malfet wants to merge 6 commits intogh/malfet/398/basefrom
malfet wants to merge 6 commits intogh/malfet/398/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155807
Note: Links to docs will display an error until the docs builds have been completed. ❌ 30 New Failures, 1 Unrelated FailureAs of commit 6a7e719 with merge base 2a3b41c ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
Looks like cuda126.ps1 and cuda129.ps1 is missing |
atalman
reviewed
Jun 12, 2025
| @@ -0,0 +1,54 @@ | |||
| # Import common functions | |||
| . "$PSScriptRoot\common.ps1" | |||
Contributor
There was a problem hiding this comment.
can we try to rewrite it so that we don't need to add cuda12X.ps1 every time so that we can specify CUDA version as a param and reuse this script across all cuda verisons ?
Contributor
Author
There was a problem hiding this comment.
Let's do it as followup...
atalman
requested changes
Jun 12, 2025
Contributor
atalman
left a comment
There was a problem hiding this comment.
Looks like this PR removes xpu.bat and cpu.bat
Contributor
|
Also instead of ps1 can we try bash script or python ? This will minimize different scripts flavors we need to support. And will make it easier for multiple team members to support these scripts (more people are familiar with bash and python) |
Contributor
Author
Did you mean cuda128? (as 129 shouldn't be there, as it does not exists) But yeah, fat fingers, added files now |
Contributor
Author
Neither are native to Windows platform |
ZainRizvi
reviewed
Jun 12, 2025
Contributor
Author
Eyeballing + CI is the best I can hope for |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
common.ps1(and check that exceptions can be propagated thru)Using Claude.AI, see https://claude.ai/share/17e72de7-282b-431a-98e8-099286c804ea and https://claude.ai/share/54ae2b87-03b0-4589-9f4b-e19e99c08d06
cc @seemethere @osalpekar @atalman