[triton pin][tests] refactor test_triton_kernel.py tests to test new & old API#155510
Closed
davidberard98 wants to merge 9 commits intogh/davidberard98/368/basefrom
Closed
[triton pin][tests] refactor test_triton_kernel.py tests to test new & old API#155510davidberard98 wants to merge 9 commits intogh/davidberard98/368/basefrom
davidberard98 wants to merge 9 commits intogh/davidberard98/368/basefrom
Conversation
This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155510
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 9e302de with merge base a205e8f ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [](https://our.internmc.facebook.com/intern/diff/) Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
3 tasks
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…o test new & old API" This splits out the tests so we can independently test both the new and old API. Note: the new API doesn't work yet - we still need to fix those tests. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov Differential Revision: [D76318840](https://our.internmc.facebook.com/intern/diff/D76318840) [ghstack-poisoned]
oulgen
approved these changes
Jun 11, 2025
This was referenced Jun 11, 2025
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Pull Request resolved: #155662 Approved by: https://github.com/aakhundov ghstack dependencies: #155510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This splits out the tests so we can independently test both the new and old API.
Note: the new API doesn't work yet - we still need to fix those tests.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov
Differential Revision: D76318840