Skip to content

[MPS] Migrate hardswish (forward and backward) to Metal kernel#155479

Closed
manuelcandales wants to merge 8 commits intogh/manuelcandales/5/basefrom
gh/manuelcandales/5/head
Closed

[MPS] Migrate hardswish (forward and backward) to Metal kernel#155479
manuelcandales wants to merge 8 commits intogh/manuelcandales/5/basefrom
gh/manuelcandales/5/head

Conversation

@manuelcandales
Copy link
Copy Markdown
Contributor

@manuelcandales manuelcandales commented Jun 9, 2025 •
edited
Loading

@manuelcandales
Update
77065dd 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jun 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155479

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 41662e9 with merge base d4d0ede (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jun 9, 2025
This was referenced Jun 9, 2025
Closed
Closed
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 9, 2025

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.

Caused by:

@manuelcandales
Update
9253b9d 
[ghstack-poisoned]
@manuelcandales
Update
a04cbfe 
[ghstack-poisoned]
@manuelcandales
Update
8401c4a 
[ghstack-poisoned]
@manuelcandales
Update
31055c0 
[ghstack-poisoned]
manuelcandales added a commit that referenced this pull request Jun 9, 2025
@manuelcandales
[MPS] Migrate hardswish (forward and backward) to Metal kernel
1511435 
ghstack-source-id: cc6a6fa
Pull-Request: #155479
manuelcandales added a commit that referenced this pull request Jun 10, 2025
@manuelcandales
[MPS] Migrate hardswish (forward and backward) to Metal kernel
7382aa3 
ghstack-source-id: cc6a6fa
Pull-Request: #155479
@manuelcandales
Update
8c65fec 
[ghstack-poisoned]
@manuelcandales manuelcandales mentioned this pull request Jun 10, 2025
Closed
@manuelcandales
Update
2ef758f 
[ghstack-poisoned]
@manuelcandales manuelcandales mentioned this pull request Jun 10, 2025
Closed
@manuelcandales
Update
41662e9 
[ghstack-poisoned]
@manuelcandales manuelcandales mentioned this pull request Jun 11, 2025
Closed
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jun 11, 2025

Starting merge as part of PR stack under #155571

pytorchmergebot pushed a commit that referenced this pull request Jun 11, 2025
@manuelcandales @pytorchmergebot
[MPS] Migrate leaky_relu (forward and backward) to Metal kernel (#155571
4609699 
)

Pull Request resolved: #155571
Approved by: https://github.com/malfet
ghstack dependencies: #155304, #155316, #155462, #155479
pytorchmergebot pushed a commit that referenced this pull request Jun 12, 2025
@manuelcandales @pytorchmergebot
[MPS] Migrate softshrink (forward and backward) to Metal kernel (#155586
851a6fa 
)

Pull Request resolved: #155586
Approved by: https://github.com/malfet
ghstack dependencies: #155304, #155316, #155462, #155479, #155571
pytorchmergebot pushed a commit that referenced this pull request Jun 23, 2025
@manuelcandales @pytorchmergebot
[MPS] Activation kernels: do compute at float precision (#155735)
e28925a 
Pull Request resolved: #155735
Approved by: https://github.com/malfet
ghstack dependencies: #155304, #155316, #155462, #155479, #155571, #155586
@github-actions github-actions bot deleted the gh/manuelcandales/5/head branch July 14, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@manuelcandales @pytorchmergebot @kulinseth @malfet