Skip to content

adding arg values and arg types to Strobelight USDT#155185

Closed
aasthashah999 wants to merge 1 commit intopytorch:mainfrom
aasthashah999:export-D75606556
Closed

adding arg values and arg types to Strobelight USDT#155185
aasthashah999 wants to merge 1 commit intopytorch:mainfrom
aasthashah999:export-D75606556

Conversation

@aasthashah999
Copy link
Contributor

Summary: This diff makes changes to the USDT added by RihamSelim in D44636587. The "operator_start" USDT passes in the memory addresses of operator arguments and the argument types. This is so we can record argument values and types in the Strobelight GPUEvent Profiler. The previous diff records the ATEN operator, and this diff lays the groundwork to record ATEN op arguments.

Test Plan: I ensured this code builds by running the example in this diff, and testing profiler changes in this diff.

Reviewed By: RihamSelim

Differential Revision: D75606556

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @aasthashah999, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155185

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 20effb0 with merge base b055611 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@aasthashah999
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 5, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Jul 7, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@aasthashah999
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 9, 2025

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@aasthashah999 aasthashah999 force-pushed the export-D75606556 branch 2 times, most recently from 2058a30 to 28f341f Compare July 10, 2025 01:24
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@aasthashah999 aasthashah999 force-pushed the export-D75606556 branch 2 times, most recently from 8485106 to ea5e587 Compare July 10, 2025 17:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@aasthashah999 aasthashah999 force-pushed the export-D75606556 branch 2 times, most recently from 53f49c7 to b62c434 Compare July 11, 2025 18:43
Summary:
Pull Request resolved: pytorch#155185

This diff makes changes to the USDT added by RihamSelim in D44636587. The "operator_start" USDT passes in the memory addresses of operator arguments and the argument types. This is so we can record argument values and types in the Strobelight GPUEvent Profiler. The previous diff records the ATEN operator, and this diff lays the groundwork to record ATEN op arguments.

Test Plan: I ensured this code builds by running the example in this diff, and testing profiler changes in this diff.

Reviewed By: malfet, RihamSelim

Differential Revision: D75606556
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75606556

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants