[nativert] Move Weights to PyTorch core#155156

Closed

yiming0416 wants to merge 1 commit intopytorch:mainfrom

yiming0416:export-D75973156

Contributor

yiming0416 commented Jun 4, 2025

Summary:
Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Differential Revision: D75973156

pytorch-bot bot commented Jun 4, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155156

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 62a1678 with merge base 2908c10 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable) (gh)
exir/backend/test/test_to_backend_multi_method.py::TestToBackendMultiMethod::test_multi_method_end_to_end

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Contributor

facebook-github-bot commented Jun 4, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

facebook-github-bot added the fb-exported label

yiming0416 marked this pull request as draft

June 4, 2025 21:17

yiming0416 added the topic: not user facing label

Contributor

facebook-github-bot commented Jun 4, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from aa50774 to 2ff5105 Compare

June 4, 2025 22:51

Contributor

facebook-github-bot commented Jun 5, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from 2ff5105 to d110bb3 Compare

June 5, 2025 01:07

yiming0416 marked this pull request as ready for review

June 5, 2025 15:52

yiming0416 requested review from Skylion007, albanD, cyyever and zhxchen17

June 5, 2025 15:52

zhxchen17 approved these changes

View reviewed changes

pytorch-bot bot added the ciflow/trunk label

Contributor

facebook-github-bot commented Jun 6, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from d110bb3 to d02270a Compare

June 6, 2025 15:36

Contributor

facebook-github-bot commented Jun 6, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request


          [nativert] Move Weights to PyTorch core (pytorch#155156)

a8d34c2

Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan: buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test

Reviewed By: zhxchen17

Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from d02270a to a8d34c2 Compare

June 6, 2025 15:42

Contributor

facebook-github-bot commented Jun 6, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from a8d34c2 to ae30a1c Compare

June 6, 2025 23:44

yiming0416 added a commit to yiming0416/pytorch that referenced this pull request


          [nativert] Move Weights to PyTorch core (pytorch#155156)

ae30a1c

Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan:
```
buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test
```

Reviewed By: zhxchen17

Differential Revision: D75973156


          [nativert] Move Weights to PyTorch core (pytorch#155156)

62a1678

Summary:
Pull Request resolved: pytorch#155156

Moves Weights class to PyTorch core
Torch Native Runtime RFC: pytorch/rfcs#72
 README: https://github.com/pytorch/pytorch/blob/main/torch/nativert/OVERVIEW.md

Test Plan:
```
buck2 run mode/dev-nosan caffe2/test/cpp/nativert:weights_test
```

Reviewed By: zhxchen17

Differential Revision: D75973156

Contributor

facebook-github-bot commented Jun 9, 2025

This pull request was exported from Phabricator. Differential Revision: D75973156

yiming0416 force-pushed the export-D75973156 branch from ae30a1c to 62a1678 Compare

June 9, 2025 00:42

sawaraken bot mentioned this pull request

PyTorch Moves 'Weights' Class to Core as Part of Native Runtime Initiative / PyTorch、「Weights」クラスをコアに移動。ネイティブランタイム構想の一環 xhiroga/news#43

Closed

Contributor

facebook-github-bot commented Jun 9, 2025

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Jun 9, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable), pull / linux-jammy-py3.9-gcc11 / test (default, 4, 5, linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

9b4a748

pytorchmergebot added Merged and removed merging labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged topic: not user facing