Skip to content

Fixes #154982: add missing to_result_dtype in vector_norm#155111

Closed
kbabiuchx wants to merge 1 commit intopytorch:mainfrom
kbabiuchx:fix-issue-154982
Closed

Fixes #154982: add missing to_result_dtype in vector_norm#155111
kbabiuchx wants to merge 1 commit intopytorch:mainfrom
kbabiuchx:fix-issue-154982

Conversation

@kbabiuchx
Copy link
Contributor

@kbabiuchx kbabiuchx commented Jun 4, 2025

Fixes #154982

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 4, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/155111

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 950706f with merge base 6737e2c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kbabiuchx / name: Kamil Babiuch (950706f)

@jcaip jcaip requested review from isuruf and laithsakka June 5, 2025 14:49
@jcaip jcaip added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 5, 2025
@isuruf isuruf added the topic: not user facing topic category label Jun 5, 2025
@kbabiuchx
Copy link
Contributor Author

kbabiuchx commented Jun 13, 2025

It looks like the CI error is not related to this change. @isuruf can you please merge?

@isuruf
Copy link
Collaborator

isuruf commented Jun 13, 2025

I don't have permission to merge here. cc @laithsakka @eellison

@Silv3S
Copy link
Contributor

Silv3S commented Jun 27, 2025

Hi @atalman, could you please help merging this? It's PT2.8 regression

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Aug 30, 2025
@isuruf isuruf removed the Stale label Sep 1, 2025
@isuruf
Copy link
Collaborator

isuruf commented Sep 1, 2025

@eellison, @laithsakka can you review?

@isuruf isuruf requested a review from eellison September 1, 2025 22:40
@isuruf
Copy link
Collaborator

isuruf commented Sep 2, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

Successfully rebased fix-issue-154982 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-issue-154982 && git pull --rebase)

@Silv3S
Copy link
Contributor

Silv3S commented Sep 4, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 4, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@kbabiuchx @markc-614
Fixes pytorch#154982: add missing to_result_dtype in vector_norm (pyt…
a14fed1 
…orch#155111)

Fixes pytorch#154982
Pull Request resolved: pytorch#155111
Approved by: https://github.com/isuruf, https://github.com/eellison
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@kbabiuchx @mansiag05
Fixes pytorch#154982: add missing to_result_dtype in vector_norm (pyt…
2e2a658 
…orch#155111)

Fixes pytorch#154982
Pull Request resolved: pytorch#155111
Approved by: https://github.com/isuruf, https://github.com/eellison
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@kbabiuchx @dsashidh
Fixes pytorch#154982: add missing to_result_dtype in vector_norm (pyt…
4397bb2 
…orch#155111)

Fixes pytorch#154982
Pull Request resolved: pytorch#155111
Approved by: https://github.com/isuruf, https://github.com/eellison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isuruf isuruf isuruf approved these changes

@eellison eellison eellison approved these changes

@laithsakka laithsakka Awaiting requested review from laithsakka

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.linalg.vector_norm fails during torch.compile due to mismatch expected out dtype tensor

7 participants

@kbabiuchx @isuruf @Silv3S @pytorchmergebot @eellison @jcaip @pytorchbot