Skip to content

Add randint_like tensor overload for high#154899

Closed
bobrenjc93 wants to merge 7 commits intogh/bobrenjc93/395/basefrom
gh/bobrenjc93/395/head
Closed

Add randint_like tensor overload for high#154899
bobrenjc93 wants to merge 7 commits intogh/bobrenjc93/395/basefrom
gh/bobrenjc93/395/head

Conversation

@bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented Jun 2, 2025 •
edited by pytorch-bot bot
Loading

@bobrenjc93
Update
55f9037 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 2, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154899

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit bfba19b with merge base 1258aac (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

bobrenjc93 added a commit that referenced this pull request Jun 2, 2025
@bobrenjc93
Remove unneeded symfloat check
814fee1 
Fixes #135664


ghstack-source-id: d215ed1
Pull-Request-resolved: #154899
@bobrenjc93 bobrenjc93 mentioned this pull request Jun 2, 2025
Closed
@bobrenjc93 bobrenjc93 requested a review from StrongerXi June 2, 2025 20:58
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label Jun 2, 2025
@bobrenjc93 bobrenjc93 marked this pull request as ready for review June 2, 2025 20:58
StrongerXi
StrongerXi approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@StrongerXi StrongerXi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bobrenjc93 bobrenjc93 closed this Jun 3, 2025
@bobrenjc93 bobrenjc93 reopened this Jun 3, 2025
@bobrenjc93
Update
e42bfac 
[ghstack-poisoned]
@bobrenjc93 bobrenjc93 changed the title Remove unneeded symfloat check Add randint_like tensor overload for high Jun 3, 2025
bdhirsh
bdhirsh reviewed Jun 3, 2025
View reviewed changes
@bobrenjc93
Update
8b6e586 
[ghstack-poisoned]
@bobrenjc93
Update
5f5b069 
[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Jun 3, 2025
@bobrenjc93
Add randint_like tensor overload for high
93fc18e 
Fixes #135664

ghstack-source-id: 22b0260
Pull-Request-resolved: #154899
@bobrenjc93 bobrenjc93 added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 3, 2025
ngimel
ngimel reviewed Jun 3, 2025
View reviewed changes
@bobrenjc93
Update
07829f6 
[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Jun 3, 2025
@bobrenjc93
Add randint_like tensor overload for high
c901181 
Fixes #135664

ghstack-source-id: 1df6dd6
Pull-Request-resolved: #154899
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Jun 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@bobrenjc93
Update
ef01726 
[ghstack-poisoned]
@bobrenjc93
Update
bfba19b 
[ghstack-poisoned]
bobrenjc93 added a commit that referenced this pull request Jun 5, 2025
@bobrenjc93
Add randint_like tensor overload for high
7d1e068 
Fixes #135664

ghstack-source-id: 0e73f5b
Pull-Request-resolved: #154899
@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Jun 5, 2025

Discussed with Eli offline and agreed we can reland

@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Jun 5, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 5, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

angelayi pushed a commit to angelayi/pytorch that referenced this pull request Jun 5, 2025
@bobrenjc93 @angelayi
Add randint_like tensor overload for high (pytorch#154899)
ec3e5f1 
Fixes pytorch#135664

Pull Request resolved: pytorch#154899
Approved by: https://github.com/StrongerXi
ghstack dependencies: pytorch#154863
angelayi pushed a commit to angelayi/pytorch that referenced this pull request Jun 5, 2025
@pytorchmergebot @angelayi
Revert "Add randint_like tensor overload for high (pytorch#154899)"
6a4068b 
This reverts commit 72fe1d5.

Reverted pytorch#154899 on behalf of https://github.com/seemethere due to Failing internal tests see https://fburl.com/diff/bai044ob ([comment](pytorch#154899 (comment)))
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 5, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Jun 5, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 5, 2025

Merge started

Your change will be merged while ignoring the following 2 checks: inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu), pull / linux-jammy-py3-clang12-executorch / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 5, 2025

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#155265

Details for Dev Infra team Raised by workflow job

@bobrenjc93
Copy link
Contributor Author

bobrenjc93 commented Jun 6, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 6, 2025

Merge started

Your change will be merged while ignoring the following 4 checks: inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu), pull / linux-jammy-py3-clang12-executorch / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/bobrenjc93/395/head branch July 9, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel left review comments

@bdhirsh bdhirsh bdhirsh left review comments

+1 more reviewer

@StrongerXi StrongerXi StrongerXi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bobrenjc93 @pytorchmergebot @seemethere @ngimel @bdhirsh @StrongerXi