[Graph Partition] support standalone_compile#154698
Closed
BoyuanFeng wants to merge 3 commits intomainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154698
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 15ff86e with merge base 28cb3c0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oulgen
reviewed
Jun 3, 2025
test/inductor/test_codecache.py
Outdated
Comment on lines
+1599
to
+1612
| def test_basic(self, device: str, format: str, dynamic: bool) -> None: | ||
| self._test_basic(device, format, dynamic) | ||
|
|
||
| @config.patch({"fx_graph_cache": True}) | ||
| @config.patch({"fx_graph_remote_cache": False}) | ||
| @functorch_config.patch({"enable_autograd_cache": True}) | ||
| @parametrize("device", (GPU_TYPE, "cpu")) | ||
| @parametrize("format", ("binary", "unpacked")) | ||
| @parametrize("dynamic", (False, True)) | ||
| @config.patch("graph_partition", True) | ||
| def test_basic_with_graph_partition( | ||
| self, device: str, format: str, dynamic: bool | ||
| ) -> None: | ||
| self._test_basic(device, format, dynamic) |
Contributor
There was a problem hiding this comment.
instead of breaking this test into two tests, make graph partition be another boolean parameter, and when use with config.patch()
oulgen
approved these changes
Jun 3, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
For graph partition, `write_get_raw_stream_header_once` is done once so the autotune code may not have the header. This PR additionally calls `write_get_raw_stream_header` in `codegen_device_guard_enter` before `get_raw_stream` is used. Pull Request resolved: pytorch#154698 Approved by: https://github.com/oulgen
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For graph partition,
write_get_raw_stream_header_onceis done once so the autotune code may not have the header. This PR additionally callswrite_get_raw_stream_headerincodegen_device_guard_enterbeforeget_raw_streamis used.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov