[1/n]adding torch.distributed.run option to provide destination for event logging#154644
Closed
[1/n]adding torch.distributed.run option to provide destination for event logging#154644
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154644
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 43e7862 with merge base 4d57644 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
7a90ce3 to
777306e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
kiukchung
pushed a commit
that referenced
this pull request
May 29, 2025
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D75183591
777306e to
3a883fe
Compare
3a883fe to
4462825
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
kiukchung
pushed a commit
that referenced
this pull request
May 30, 2025
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D75183591
5c67c54 to
a6336bd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
kiukchung
pushed a commit
that referenced
this pull request
May 30, 2025
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D75183591
a6336bd to
7df7b53
Compare
7df7b53 to
cd14e15
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
kiukchung
pushed a commit
that referenced
this pull request
Jun 2, 2025
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D75183591
cd14e15 to
f4640f3
Compare
f4640f3 to
158fc98
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
kiukchung
pushed a commit
that referenced
this pull request
Jun 2, 2025
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Differential Revision: D75183591
158fc98 to
08657e6
Compare
08657e6 to
1378f98
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
1378f98 to
24efe9f
Compare
24efe9f to
a9a5241
Compare
…vent logging (#154644) Summary: Pull Request resolved: #154644 **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: ``` buck test //caffe2/test/distributed:distributed_run_test ``` https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Rollback Plan: Reviewed By: kiukchung Differential Revision: D75183591
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75183591 |
a9a5241 to
43e7862
Compare
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 9, 2025
…vent logging (#154644) (#155268) Summary: **Problem Statement** Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run. *recording events to default destination:* https://fburl.com/code/7f9b0993 The default destination is "null". ***Solution*** adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line. Test Plan: https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION Rollback Plan: Reviewed By: kiukchung Differential Revision: D75183591 Pull Request resolved: #155268 Approved by: https://github.com/d4l3k
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem Statement
Currently, torch distributed elastic does not support to an option specify destination for event logging from torch.distributed.run.
recording events to default destination: https://fburl.com/code/7f9b0993
The default destination is "null".
Solution
adding option in torch.destributed.run to specify event_logging_destination. The default value will be "null" which is current default so it won;t affect users unless the specify it via command line.
Test Plan:
https://www.internalfb.com/mlhub/pipelines/runs/mast/f738408681-TrainingApplication_torch_distributed_run_3?job_attempt=0&version=0&tab=execution_details&env=PRODUCTION
Differential Revision: D75183591
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta