Skip to content

Removing per torch.compile audit.#154572

Closed
AlannaBurke wants to merge 2 commits intopytorch:mainfrom
AlannaBurke:torchcompile-deletions
Closed

Removing per torch.compile audit.#154572
AlannaBurke wants to merge 2 commits intopytorch:mainfrom
AlannaBurke:torchcompile-deletions

Conversation

@AlannaBurke
Copy link
Contributor

@AlannaBurke AlannaBurke commented May 28, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented May 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154572

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6c9625e with merge base 0db9c64 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@AlannaBurke AlannaBurke added compile-docs module: docs Related to our documentation, both in docs/ and docblocks and removed compile-docs labels May 28, 2025
@svekars
Copy link
Contributor

svekars commented May 28, 2025

can we remove from here as well:

pytorch/docs/source/torch.compiler.rst

Line 110 in 0c00e32

torch.compiler_best_practices_for_backends

@svekars svekars added topic: not user facing topic category topic: docs topic category labels May 28, 2025
svekars
svekars approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svekars
Copy link
Contributor

svekars commented May 29, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 29, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 29, 2025

Successfully rebased torchcompile-deletions onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout torchcompile-deletions && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the torchcompile-deletions branch from 44c9b37 to 6c9625e Compare May 29, 2025 21:56
@svekars
Copy link
Contributor

svekars commented Jun 3, 2025

@pytorchbot merge -f "Docs only change"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jun 3, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

iupaikov-amd pushed a commit to ROCm/pytorch that referenced this pull request Jun 4, 2025
@AlannaBurke @iupaikov-amd
Removing per torch.compile audit. (pytorch#154572)
803d7b6 
Removing https://pytorch.org/docs/stable/torch.compiler_best_practices_for_backends.html per torch.compile audit

Pull Request resolved: pytorch#154572
Approved by: https://github.com/williamwen42, https://github.com/svekars
angelayi pushed a commit to angelayi/pytorch that referenced this pull request Jun 5, 2025
@AlannaBurke @angelayi
Removing per torch.compile audit. (pytorch#154572)
e3e51a3 
Removing https://pytorch.org/docs/stable/torch.compiler_best_practices_for_backends.html per torch.compile audit

Pull Request resolved: pytorch#154572
Approved by: https://github.com/williamwen42, https://github.com/svekars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svekars svekars svekars approved these changes

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

compile-docs Merged module: docs Related to our documentation, both in docs/ and docblocks topic: docs topic category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlannaBurke @svekars @pytorchmergebot @williamwen42