[cpp_wrapper] Build main and kernel code in separate threads#154551
Closed
benjaminglass1 wants to merge 37 commits intogh/benjaminglass1/86/basefrom
Closed
[cpp_wrapper] Build main and kernel code in separate threads#154551benjaminglass1 wants to merge 37 commits intogh/benjaminglass1/86/basefrom
benjaminglass1 wants to merge 37 commits intogh/benjaminglass1/86/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154551
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 04c49e9 with merge base e785c08 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5 tasks
benjaminglass1
commented
Jul 10, 2025
Comment on lines
+1606
to
+1631
| if _IS_WINDOWS: | ||
| # https://learn.microsoft.com/en-us/cpp/build/walkthrough-compile-a-c-program-on-the-command-line?view=msvc-1704 | ||
| # https://stackoverflow.com/a/31566153 | ||
| cmd = ( | ||
| f"{self._compiler} {self._include_dirs_args} {self._definitions_args} " | ||
| f"{self._cflags_args} {self._sources_args} " | ||
| f"{self._passthrough_parameters_args} {self._output}" | ||
| ) | ||
| if self._do_link: | ||
| cmd += ( | ||
| f" /LD /link {self._libraries_dirs_args} {self._libraries_args} " | ||
| f"{self._ldflags_args}" | ||
| ) | ||
| if self._do_link: | ||
| cmd += f" {ldflags_args} {libraries_args} {libraries_dirs_args}" | ||
| return cmd | ||
|
|
||
| command_line = format_build_command( | ||
| compiler=self._compiler, | ||
| sources=self._sources_args, | ||
| include_dirs_args=self._include_dirs_args, | ||
| definitions_args=self._definitions_args, | ||
| cflags_args=self._cflags_args, | ||
| ldflags_args=self._ldflags_args, | ||
| libraries_args=self._libraries_args, | ||
| libraries_dirs_args=self._libraries_dirs_args, | ||
| passthrough_args=self._passthrough_parameters_args, | ||
| output=self._output, | ||
| return normalize_path_separator(cmd) | ||
|
|
||
| cmd = ( | ||
| f"{self._compiler} {self._sources_args} {self._definitions_args} " | ||
| f"{self._cflags_args} {self._include_dirs_args} " | ||
| f"{self._passthrough_parameters_args} {self._output}" | ||
| ) | ||
| return command_line | ||
| if self._do_link: | ||
| cmd += ( | ||
| f" {self._ldflags_args} {self._libraries_args} " | ||
| f"{self._libraries_dirs_args}" | ||
| ) | ||
| return cmd |
Collaborator
Author
There was a problem hiding this comment.
This is functionally neutral; it just removes an interior function that added extra indentation and was only called here.
benjaminglass1
added a commit
that referenced
this pull request
Jul 30, 2025
The main change of this commit is building cpp_wrapper code asynchronously, with a thread for the wrapper code, a thread for the kernel code, and a final thread to link. This improves build speeds, even while enabling an LTO link to improve performance. Additionally, significantly reduce the cold-start time for detecting compatible precompiled headers. We had accidentally preprocessed the underlying header in -O3, which is deeply unnecessary to simply detect content changes. ghstack-source-id: ad74c56 Pull Request resolved: #154551
benjaminglass1
added a commit
that referenced
this pull request
Jul 30, 2025
The main change of this commit is building cpp_wrapper code asynchronously, with a thread for the wrapper code, a thread for the kernel code, and a final thread to link. This improves build speeds, even while enabling an LTO link to improve performance. Additionally, significantly reduce the cold-start time for detecting compatible precompiled headers. We had accidentally preprocessed the underlying header in -O3, which is deeply unnecessary to simply detect content changes. ghstack-source-id: ad74c56 Pull Request resolved: #154551
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The main change of this commit is building
cpp_wrappercode asynchronously, with a thread for the wrapper code, a thread for the kernel code, and a final thread to link. This improves build speeds, even while enabling an LTO link to improve performance.Additionally, significantly reduce the cold-start time for detecting compatible precompiled headers. We had accidentally preprocessed the underlying header in
-O3, which is deeply unnecessary to simply detect content changes.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela