[1/3] Add header file for Graph in nativert#154530
Closed
yiming0416 wants to merge 6 commits intogh/yiming0416/5/basefrom
Closed
[1/3] Add header file for Graph in nativert#154530yiming0416 wants to merge 6 commits intogh/yiming0416/5/basefrom
yiming0416 wants to merge 6 commits intogh/yiming0416/5/basefrom
Conversation
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154530
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit 3c00d19 with merge base 388912d ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 28, 2025
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75491860 |
SherlockNoMad
approved these changes
Jun 3, 2025
Contributor
|
splitting a header file apart from a source file seems like too much splitting. I guess this is because of pr-sanity-checks on #153994? |
Contributor
Author
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
Starting merge as part of PR stack under #154531 |
Collaborator
|
Starting merge as part of PR stack under #154532 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 3, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. **Add source file** 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75492405](https://our.internmc.facebook.com/intern/diff/D75492405/) Pull Request resolved: #154531 Approved by: https://github.com/SherlockNoMad ghstack dependencies: #154530
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 3, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. Add source file 3. **Add test and build rules** Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75495273](https://our.internmc.facebook.com/intern/diff/D75495273/) Pull Request resolved: #154532 Approved by: https://github.com/SherlockNoMad ghstack dependencies: #154530, #154531
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) Pull Request resolved: pytorch#154530 Approved by: https://github.com/SherlockNoMad
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. **Add source file** 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75492405](https://our.internmc.facebook.com/intern/diff/D75492405/) Pull Request resolved: pytorch#154531 Approved by: https://github.com/SherlockNoMad ghstack dependencies: pytorch#154530
iupaikov-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Jun 4, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. Add source file 3. **Add test and build rules** Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75495273](https://our.internmc.facebook.com/intern/diff/D75495273/) Pull Request resolved: pytorch#154532 Approved by: https://github.com/SherlockNoMad ghstack dependencies: pytorch#154530, pytorch#154531
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
We split the large PR for adding Graph.h and Graph.cpp to `nativert` into 3 smaller PRs: 1. **Add header file** 2. Add source file 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75491860](https://our.internmc.facebook.com/intern/diff/D75491860/) Pull Request resolved: pytorch#154530 Approved by: https://github.com/SherlockNoMad
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. **Add source file** 3. Add test and build rules. Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75492405](https://our.internmc.facebook.com/intern/diff/D75492405/) Pull Request resolved: pytorch#154531 Approved by: https://github.com/SherlockNoMad ghstack dependencies: pytorch#154530
angelayi
pushed a commit
to angelayi/pytorch
that referenced
this pull request
Jun 5, 2025
We split the large PR for adding Graph.h and Graph.cpp to nativert into 3 smaller PRs: 1. Add header file 2. Add source file 3. **Add test and build rules** Torch Native Runtime RFC: pytorch/rfcs#72 4 classes have been introduced: `Graph`, `Node`, `Value`, `Type` - `Type` represents the kind of a `Value` - `Value` represents a single symbolic value, it could be any kind that exists in `Type`. Values are inputs and outputs of a `Node`. - `Node` represents a single unit of execution, typically a PyTorch op. - `Graph` represents a model's computation graph, which is designed to facilitate transformation/analysis. Differential Revision: [D75495273](https://our.internmc.facebook.com/intern/diff/D75495273/) Pull Request resolved: pytorch#154532 Approved by: https://github.com/SherlockNoMad ghstack dependencies: pytorch#154530, pytorch#154531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We split the large PR for adding Graph.h and Graph.cpp to
nativertinto 3 smaller PRs:Torch Native Runtime RFC: pytorch/rfcs#72
4 classes have been introduced:
Graph,Node,Value,TypeTyperepresents the kind of aValueValuerepresents a single symbolic value, it could be any kind that exists inType. Values are inputs and outputs of aNode.Noderepresents a single unit of execution, typically a PyTorch op.Graphrepresents a model's computation graph, which is designed to facilitate transformation/analysis.Differential Revision: D75491860